Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: gradle cleanup #1253

Merged
merged 5 commits into from
Jul 6, 2021
Merged

refactor: gradle cleanup #1253

merged 5 commits into from
Jul 6, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 6, 2021 •
edited
Loading

Motivation and Context

Continue Gradle Cleanup

  • Removed an unnecessary cordova.gradle apply
  • Moved AndroidX WebKit version to defaults.
  • Maven Publish to pull version from package.json
  • Separated the framwork publishing logic outside of app dev scope

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021 •
edited
Loading

Codecov Report

Merging #1253 (517da50) into master (69b24db) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1253   +/-   ##
=======================================
  Coverage   71.08%   71.08%           
=======================================
  Files          22       22           
  Lines        1705     1705           
=======================================
  Hits         1212     1212           
  Misses        493      493

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b24db...517da50. Read the comment docs.

@erisu erisu changed the title Refactor/gradle cleanup refactor: gradle cleanup Jul 6, 2021
@erisu erisu mentioned this pull request Jul 6, 2021
Merged
2 tasks
@erisu
Copy link
Member Author

erisu commented Jul 6, 2021

If there no review, I will merge within 12 hours.

breautek
breautek approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erisu erisu merged commit e8cbeaa into apache:master Jul 6, 2021
@erisu erisu deleted the refactor/gradle-cleanup branch July 6, 2021 13:38
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
@erisu @wedgberto
refactor: gradle cleanup (apache#1253)
4523caa 
* refactor: move androidx.webkit version to cdv-gradle-config-defaults
* chore: remove unnecessary cordova.gradle apply
* refactor: maven publish to use version info from package.json
* refactor: separate framwork publishing outside of app dev scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breautek breautek breautek approved these changes

@jcesarmobile jcesarmobile Awaiting requested review from jcesarmobile

@raphinesse raphinesse Awaiting requested review from raphinesse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erisu @codecov-commenter @breautek