Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: drop jcenter/bintray & update dependencies #1251

Merged
merged 1 commit into from
Jul 3, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Jul 2, 2021

Motivation, Context & Description

  • Remove JCenter usage
  • Remove Bintray usage
  • Replace & Upgrade com.g00fy2:versioncompare:1.3.4 with io.github.g00fy2:versioncompare:1.4.1
  • Update all repositories definitions with:
repositories {
    google()
    mavenCentral()
}

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2021

Codecov Report

Merging #1251 (8f9ad2c) into master (015db81) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1251   +/-   ##
=======================================
  Coverage   71.90%   71.90%           
=======================================
  Files          21       21           
  Lines        1694     1694           
=======================================
  Hits         1218     1218           
  Misses        476      476           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 015db81...8f9ad2c. Read the comment docs.

@erisu
Copy link
Member Author

erisu commented Jul 2, 2021

I have rebased this PR with the correct repository order based on feedback provided by @jcesarmobile here: #1252 (comment)

@erisu erisu changed the title breaking!: drop jcenter/bintray & update dependencies breaking: drop jcenter/bintray & update dependencies Jul 3, 2021
@erisu erisu merged commit 47aa116 into apache:master Jul 3, 2021
@erisu erisu deleted the feat/drop-jcenter-usage branch July 3, 2021 04:04
sakibguy added a commit to sakibguy/cordova-android that referenced this pull request Jul 4, 2021
breaking: drop jcenter & update dependencies (apache#1251)
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants