Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unit-test failure #1184

Merged
merged 1 commit into from
Mar 30, 2021
Merged

fix: unit-test failure #1184

merged 1 commit into from
Mar 30, 2021

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 30, 2021

Motivation and Context

expectAsync need await. With out await, tests can fail.

Description

  • Added await & async where needed.

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added the bug label Mar 30, 2021
@erisu erisu added this to the 9.1.0 milestone Mar 30, 2021
@erisu erisu requested a review from NiklasMerz March 30, 2021 09:23
@erisu erisu merged commit 6dcd67a into apache:master Mar 30, 2021
@erisu erisu deleted the fix/unit-test-missing-await branch March 30, 2021 09:46
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
@erisu @wedgberto
fix: unit-test failure (apache#1184)
3d2cc79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasMerz NiklasMerz NiklasMerz approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@erisu @NiklasMerz