feat: upgrade Google Services Gradle Plugin [email protected]

[mosabab]

Platforms affected

Android

Motivation and Context

Google Services Gradle Plugin @4.3.5

Description

Testing

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[timbru31]

@erisu can't this go to the 9.1.0 milestone, too? SemVer wise it looks non-breaking. Are we aware of any breaking changes in the plugin?

[erisu]

@timbru31 The Google Services plugin I am not entirely sure if it is safe or not for a minor release.

By following semver's rules, this should be safe for our minor release. But looking back at other Google libraries, for example, the Firebase library, they did not follow semver. In one of their minor release, it dropped ASL for Android X.

Since I kinda felt that Google Services might go hand-in-hand with the Firebase service, I kinda questioned if it was safe or not.

If there is any evidence that this plugin wouldn't be an issue for our minor release, then I am not against releasing it with our minor release.

[timbru31]

Changelog wise this looks OK for a minor:

• https://firebase.google.com/support/release-notes/android#google-services_plugin_v4-3-5
• https://firebase.google.com/support/release-notes/android#google-services_plugin_v4-3-4
• https://firebase.google.com/support/release-notes/android#google-services_plugin_v4-3-2
• https://firebase.google.com/support/release-notes/android#google-services_plugin_v4-3-1
• https://firebase.google.com/support/release-notes/android#google-services_plugin_v4-3-0