Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle intent:// scheme links with browser_fallback_url param #1167

Merged
merged 5 commits into from
Mar 30, 2021

Conversation

x-and
Copy link
Contributor

@x-and x-and commented Feb 20, 2021

Platforms affected

Android

Motivation and Context

unhandled intent:// links with browser_fallback_url param

Description

Testing

Without yandex map app link open fallback url in browser.

D/CordovaWebViewImpl: showWebPage(intent://maps.yandex.ru/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps&utm_medium=sevstar.net#Intent;scheme=http;package=ru.yandex.yandexmaps;S.browser_fallback_url=https://yandex.ru/maps/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps;end, true, false, HashMap)
D/CordovaWebViewImpl: showWebPage(https://yandex.ru/maps/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps, true, false, HashMap)

With yandex map app intent open yandexmap

D/CordovaWebViewImpl: showWebPage(intent://maps.yandex.ru/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps&utm_medium=sevstar.net#Intent;scheme=http;package=ru.yandex.yandexmaps;S.browser_fallback_url=https://yandex.ru/maps/?z=11&ll=45.501576999999976,50.57730000002066&l=map&source=jsapi_2_1_78&from=api-maps&utm_source=api-maps;end, true, false, HashMap)

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-io
Copy link

codecov-io commented Feb 20, 2021

Codecov Report

Merging #1167 (114569d) into master (a45217e) will increase coverage by 2.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1167      +/-   ##
==========================================
+ Coverage   69.06%   71.80%   +2.73%     
==========================================
  Files          20       21       +1     
  Lines        1833     1745      -88     
==========================================
- Hits         1266     1253      -13     
+ Misses        567      492      -75     
Impacted Files Coverage Δ
bin/templates/cordova/lib/Adb.js 100.00% <0.00%> (ø)
bin/templates/cordova/lib/run.js 100.00% <0.00%> (ø)
bin/templates/cordova/lib/retry.js 100.00% <0.00%> (ø)
bin/templates/cordova/lib/device.js 100.00% <0.00%> (ø)
bin/templates/cordova/lib/target.js 96.77% <0.00%> (ø)
bin/templates/cordova/lib/emulator.js 98.84% <0.00%> (+0.71%) ⬆️
...n/templates/cordova/lib/builders/ProjectBuilder.js 74.83% <0.00%> (+1.62%) ⬆️
bin/templates/cordova/lib/build.js 33.33% <0.00%> (+2.22%) ⬆️
bin/templates/cordova/lib/prepare.js 47.79% <0.00%> (+4.20%) ⬆️
bin/templates/cordova/lib/check_reqs.js 70.24% <0.00%> (+10.80%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45217e...114569d. Read the comment docs.

@breautek breautek added this to the 9.1.0 milestone Mar 27, 2021
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok.

The PR will need to be rebased to deal with merge conflicts.

@erisu erisu changed the title improve: handle link scheme intent:// with browser_fallback_url param feat: handle intent:// scheme links with browser_fallback_url param Mar 28, 2021
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erisu erisu merged commit d22af02 into apache:master Mar 30, 2021
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
…pache#1167)

* fix showWebPage url intent:// now works
* android handle external url `intent://` scheme
* code refactoring

Co-authored-by: Андреянов Александр Николаевич <[email protected]>
Co-authored-by: Tim Brust <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants