-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle intent:// scheme links with browser_fallback_url param #1167
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1167 +/- ##
==========================================
+ Coverage 69.06% 71.80% +2.73%
==========================================
Files 20 21 +1
Lines 1833 1745 -88
==========================================
- Hits 1266 1253 -13
+ Misses 567 492 -75
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks ok.
The PR will need to be rebased to deal with merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…pache#1167) * fix showWebPage url intent:// now works * android handle external url `intent://` scheme * code refactoring Co-authored-by: Андреянов Александр Николаевич <[email protected]> Co-authored-by: Tim Brust <[email protected]>
Platforms affected
Android
Motivation and Context
unhandled intent:// links with browser_fallback_url param
Description
Testing
Without yandex map app link open fallback url in browser.
With yandex map app intent open yandexmap
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)