feat: overload PluginEntry constructor to set onload property #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblejder
changed the title
jblejder
force-pushed
the
instanciated-plugins
branch
from
b8aee02
to
b86751d
Compare
jblejder
force-pushed
the
instanciated-plugins
branch
from
b86751d
to
f2a0f06
Compare
erisu
changed the title
timbru31
requested changes
Apr 7, 2021
| @@ -52,6 +52,10 @@ public PluginEntry(String service, CordovaPlugin plugin) { | |||
| this(service, plugin.getClass().getName(), true, plugin); | |||
| } | |||
|
|
|||
| public PluginEntry(String service, CordovaPlugin plugin, boolean onload) { | |||
There was a problem hiding this comment.
Could you add a JavaDoc comment for this overload? Thanks!
There was a problem hiding this comment.
@jblejder would you be able to add in the JavaDoc comment?
You can use the below public PluginEntry overloaded method's comment block as an example for your overloaded method.
After this PR is updated, I can merge it in for next release.
Codecov Report
@@ Coverage Diff @@
## master #1166 +/- ##
=========================================
Coverage ? 71.97%
=========================================
Files ? 21
Lines ? 1695
Branches ? 0
=========================================
Hits ? 1220
Misses ? 475
Partials ? 0 Continue to review full report at Codecov.
|
erisu
approved these changes
Apr 18, 2021
wedgberto
pushed a commit
to wedgberto/cordova-android
that referenced
this pull request
May 17, 2022
…#1166) Co-authored-by: Erisu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
resolves #1164
This will allow to specify already instantiated PluginEntries with
onload = false.Which will stop Cordova from initialising them multiple time and fix issue on AGP 4.1.2 that enables all asserts in debug
Is setting onLoad false valid option here?
Testing
have a look at test exposing issue:
jblejder#1
Checklist
(platform)if this change only applies to one platform (e.g.(android))