Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optional arch parameter #1153

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Conversation

breautek
Copy link
Contributor

Platforms affected

Android

Motivation and Context

Building bundles broke at some point between 9.0.0 and nightly.

Fixes #1151

Description

When building bundles, the arch setting is not supplied. This is provided through an options parameter, but you cannot deconstruct a object that doesn't exists. Therefore, I made the options parameter default to {}. The arch option remains optional.

Testing

Ran npm test.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek
Copy link
Contributor Author

Thanks for the review

@breautek breautek merged commit 3081e5e into apache:master Jan 20, 2021
@breautek breautek deleted the fix/arch-error branch January 20, 2021 01:33
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android bundle package could not be produced using cordova build android --release
2 participants