refactor: unify installation on devices & emulators #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
- Coverage 71.41% 70.97% -0.44%
==========================================
Files 20 21 +1
Lines 1770 1747 -23
==========================================
- Hits 1264 1240 -24
- Misses 506 507 +1
Continue to review full report at Codecov.
|
|
This change is actually not independent from #1101. Sorry for the bother. Closing. |
|
OK, I fixed this PR up and it is now independent and ready to review. Sorry for the inconvenience. |
raphinesse
added a commit
to raphinesse/cordova-android
that referenced
this pull request
Nov 17, 2020
raphinesse
added a commit
to raphinesse/cordova-android
that referenced
this pull request
Nov 17, 2020
This change replaces the almost identical methods `device.install` and `emulator.install` with the generic `target.install`.
raphinesse
force-pushed
the
unified-installation
branch
from
188d885
to
6737629
Compare
raphinesse
added a commit
to raphinesse/cordova-android
that referenced
this pull request
Nov 19, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
device.installandemulator.installare virtually identical. The only notable difference is thatemulator.installhas some retry logic that is supposed to mitigate emulator hangs. The same goes for the unit tests.Joining these methods reduces the code we have to maintain and makes upcoming refactors easier.
Description
This change replaces
device.installandemulator.installwith the generictarget.install.The old installation methods did also resolve the passed target specification (by calling
{device,emulator}.resolveTarget) if necessary. The new installation method expects the given installation target to be resolved already. This allows for a better separation of concerns.Testing
TypeError: Cannot read property 'apkPaths' of undefined)