refactor: remove copied Adb.install from emulator.install #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`emulator.install` contains a copy of the code of `Adb.install` just to be able to pass custom options to `execa`. This change removes that duplicated code in favor of a new option in `Adb.install` that allows to pass through options to `execa`.
raphinesse
added a commit
to raphinesse/cordova-android
that referenced
this pull request
Oct 22, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
emulator.installcontains a copy of the code ofAdb.installjust to be able to pass custom options toexeca.Description
This change removes that duplicated code in favor of a new option in
Adb.installthat allows to pass through options toexeca.Testing
Unit tests.