Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(utils): reduce number of utils #1085

Merged
merged 2 commits into from
Oct 6, 2020
Merged

refactor(utils): reduce number of utils #1085

merged 2 commits into from
Oct 6, 2020

Conversation

raphinesse
Copy link
Contributor

Motivation and Context

Reduce amount of code to maintain.

Description

  • Inlined utils.grep at only point of usage
  • Replaced utils.scanDirectory with fast-glob

Testing

Existing tests pass

@raphinesse raphinesse added this to the 9.0.1 milestone Oct 5, 2020
@raphinesse raphinesse merged commit 5d3591b into apache:master Oct 6, 2020
@raphinesse raphinesse deleted the less-utils branch October 6, 2020 07:04
@dpogue dpogue mentioned this pull request Oct 7, 2020
Open
@raphinesse raphinesse mentioned this pull request Nov 29, 2020
Merged
@breautek breautek mentioned this pull request Jan 20, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breautek breautek breautek approved these changes

@erisu erisu erisu approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
9.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@raphinesse @erisu @breautek