Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(pluginHandlers/common): better setup & teardown #1013

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Jul 2, 2020

Motivation and Context

  • test file setup was overly verbose
  • teardown was faulty (exceptions in tests could lead to files being left behind)
  • I wanted to add a regression test to the suite

Description

  • use fs.outputFileSync to create files and their parent dirs
  • use afterEach to reliably clean up after tests

Testing

Affected unit tests still pass

@raphinesse raphinesse merged commit 80ad635 into apache:master Jul 8, 2020
@raphinesse raphinesse deleted the handler-spec branch July 8, 2020 13:15
@raphinesse
Copy link
Contributor Author

Thanks for the review, @timbru31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants