Skip to content

Update exception message in CSVRecord#getNextRecord() #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 3 commits into from
Aug 30, 2023
+1 −1
Merged

Update exception message in CSVRecord#getNextRecord() #348

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bde990
removing duplicated exception class name from error message
gbidsilva Aug 30, 2023
eaba341
removing unwanted files
gbidsilva Aug 30, 2023
dbc418b
Update CSVParser.java
garydgregory Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/commons/csv/CSVParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ private CSVRecord getNextRecord() {
try {
return CSVParser.this.nextRecord();
} catch (final IOException e) {
throw new UncheckedIOException(e.getClass().getSimpleName() + " reading next record: " + e.toString(), e);
throw new UncheckedIOException("Error in reading next record: " + e.toString(), e);

@michael-o michael-o Aug 30, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just throw new UncheckedIOException("Error in reading next record", e);? No duplication. Plain and simple.

@gbidsilva gbidsilva Aug 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be the intention was to provide the sense of error in the message itself.

@garydgregory garydgregory Aug 30, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not an Error... See below.

@garydgregory garydgregory Aug 30, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Error" has a specific meaning in Java, and we did not catch a java.lang.Error here. Saying "Exception reading next record..." is more accurate than "Error ...", then the difference is whether the sentence starts with "Exception ..." vs. "IOException..." (or a subclass), so the difference is not interesting IMO. Or, we could say "CSVParser#nextRecord(): " + e where the (maybe dubious) benefit is that it is a touch more language-neutral.

Thoughts?

@gbidsilva gbidsilva Aug 30, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel "Exception reading next record" would be more meaningful.

@michael-o michael-o Aug 30, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just: "Failed to read next record"?

}
}

Expand Down