Make XHTML example more null-safe

apache · Oct 18, 2024 · 9f5a4d9 · 9f5a4d9
1 parent b6c2c59
commit 9f5a4d9
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/test/java/org/apache/commons/cli/example/XhtmlHelpAppendable.java b/src/test/java/org/apache/commons/cli/example/XhtmlHelpAppendable.java
@@ -19,6 +19,7 @@ Licensed to the Apache Software Foundation (ASF) under one or more
 import java.io.IOException;
 import java.util.Collection;
 import java.util.List;
+import java.util.Objects;
 
 import org.apache.commons.cli.help.FilterHelpAppendable;
 import org.apache.commons.cli.help.TableDefinition;
@@ -46,7 +47,7 @@ public void appendHeader(final int level, final CharSequence text) throws IOExce
             if (level < 1) {
                 throw new IllegalArgumentException("level must be at least 1");
             }
-            appendFormat("<h%s>%s</h%1$s>%n", level, StringEscapeUtils.escapeHtml4(text.toString()));
+            appendFormat("<h%s>%s</h%1$s>%n", level, StringEscapeUtils.escapeHtml4(Objects.toString(text)));
         }
     }
 
@@ -62,7 +63,7 @@ public void appendList(final boolean ordered, final Collection<CharSequence> lis
     @Override
     public void appendParagraph(final CharSequence paragraph) throws IOException {
         if (StringUtils.isNotEmpty(paragraph)) {
-            appendFormat("<p>%s</p>%n", StringEscapeUtils.escapeHtml4(paragraph.toString()));
+            appendFormat("<p>%s</p>%n", StringEscapeUtils.escapeHtml4(Objects.toString(paragraph)));
         }
     }
 
@@ -93,6 +94,6 @@ public void appendTable(final TableDefinition table) throws IOException {
 
     @Override
     public void appendTitle(final CharSequence title) throws IOException {
-        appendFormat("<span class='commons_cli_title'>%s</span>%n", StringEscapeUtils.escapeHtml4(title.toString()));
+        appendFormat("<span class='commons_cli_title'>%s</span>%n", StringEscapeUtils.escapeHtml4(Objects.toString(title)));
     }
 }