fix asterisk encoding

[poddm]

Resolving errors when Configuration values contain an asterisk.

Error: CloudStack API error 401 (CSExceptionErrorCode: 0): unable to verify user credentials and/or request signature

Found the following note here:

If you have API calls which contain * (asterisk) characters, you will need to add the option “safe = ‘’” for the URL encoding. The reason is that Python’s urllib will encode * characters by default, while CloudStack’s internal encoder does not encode them; this results in an authentication failure for your API call. In the above you would replace “urllib.quote_plus(request[k])” with “urllib.quote_plus(request[k], safe=’’)”.

[mlsorensen]

Good catch @poddm - I've run into this as well. My only feedback is that maybe if the implementation were within encodeValuesinstead, it would be easy to add some tests.

[rohityadavcloud]

Would you think this also affects cmk cc @mlsorensen ? The referenced docs are quite old and written for Python, the more recent Go implementation in cmk uses this code for network request:
https://github.com/apache/cloudstack-cloudmonkey/blob/main/cmd/network.go

[mlsorensen]

It does, you can't set a value with an asterisk via the Go implementation of cloudmonkey.

[rohityadavcloud]

Thanks @mlsorensen, @poddm https://github.com/apache/cloudstack-cloudmonkey/blob/main/cmd/network.go can use a PR as well.

[mlsorensen]

@poddm looks like the change would need to be made in the generate.go in order to stick, since the code changed is generated.

cloudstack-go/generate/generate.go

Line 529 in 0106fc7

pn("func (cs *CloudStackClient) newRawRequest(api string, post bool, params url.Values) (json.RawMessage, error) {")

[poddm]

@mlsorensen, overlooked this. I'll update the PR.

[mlsorensen]

@poddm see what you think about #52

[poddm]

lgtm -

[shwstppr]

@poddm @mlsorensen do we need this now as #52 is already merged?

[mlsorensen]

@poddm @mlsorensen do we need this now as #52 is already merged?

I don't think so, #52 covers it.