Skip to content

Conversation

@nvazquez
Copy link
Contributor

Fixes: #128

Incorporating changes from: apache/cloudstack-go#52

  • Tested:
(localcloud) 🐱 > update configuration name=consoleproxy.url.domain value=*.example.org
{
  "configuration": {
    "category": "Console Proxy",
    "description": "Console proxy url domain",
    "isdynamic": false,
    "name": "consoleproxy.url.domain",
    "value": "*.example.org"
  }
}

Passes the asterisk correctly and is not encoded

2023-04-10 11:18:56,946 DEBUG [c.c.a.ApiServlet] (qtp2129144075-16:ctx-b28b0063) (logid:44b8995f) ===START===  10.0.3.251 -- GET  apiKey=LIN6rqXuaJwMPfGYFh13qDwYz5VNNz1J2J6qIOWcd3oLQOq0WtD4CwRundBL6rzXToa3lQOC_vKjI3nkHtiD8Q&command=updateConfiguration&name=consoleproxy.url.domain&response=json&value=*.example.org&signature=00AgwiNGweTliSZKGFyGIHUGSyM%3D

@nvazquez nvazquez added the bug label Apr 10, 2023
@nvazquez nvazquez added this to the 6.3.0 milestone Apr 10, 2023
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test it

@borisstoyanov
Copy link
Contributor

Thanks @rohityadavcloud and @nvazquez will test it manually and merge it

Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've manually tested it

@borisstoyanov borisstoyanov merged commit f43904f into apache:main Apr 21, 2023
@nvazquez nvazquez deleted the allow-asterisk-values branch April 24, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow cmk to pass * as parameter value

3 participants