Skip to content

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Dec 19, 2025

What changes were proposed in this pull request?

Adapt to SPARK-51756, which changes the MapStatus API used by Celeborn.

Why are the changes needed?

A necessary step to make Celeborn support Spark 4.1.

Does this PR resolve a correctness bug?

No.

Does this PR introduce any user-facing change?

Yes, it makes

How was this patch tested?

Have integrated with Spark 4.1 in the internal test env, and verified by some simple queries.

@pan3793 pan3793 marked this pull request as ready for review December 19, 2025 12:53

private static final DynMethods.BoundMethod MAP_STATUS_APPLY_METHOD =
DynMethods.builder("apply")
// for SPARK-51756 (4.1.0) and later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apache/spark#50230

SPARK-54663 or SPARK-51756

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about add the PR title as well, the new field is checksumValue.

Copy link
Member Author

@pan3793 pan3793 Dec 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, seems the author changes the JIRA ticket in the PR title after merging -

  • the git commit history is SPARK-51756
  • the final PR title is changed to SPARK-54663

not a big deal, since SPARK-54663 is a sub-task of SPARK-51756.

@pan3793 pan3793 changed the title [CELEBORN-2240] Adapt to SPARK-51756 [CELEBORN-2240] Adapt to SPARK-51756 which add a new parameter checksumValue in MapStatus.apply Dec 20, 2025
@pan3793 pan3793 self-assigned this Dec 20, 2025
@pan3793 pan3793 closed this in 526f7bb Dec 20, 2025
@pan3793
Copy link
Member Author

pan3793 commented Dec 20, 2025

thanks, merged to main for 0.7.0

@pan3793 pan3793 deleted the CELEBORN-2240 branch December 20, 2025 15:47
xy2953396112 pushed a commit to xy2953396112/celeborn that referenced this pull request Dec 25, 2025
…sumValue` in `MapStatus.apply`

Adapt to SPARK-51756, which changes the MapStatus API used by Celeborn.

A necessary step to make Celeborn support Spark 4.1.

No.

Yes, it makes

Have integrated with Spark 4.1 in the internal test env, and verified by some simple queries.

Closes apache#3570 from pan3793/CELEBORN-2240.

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants