-
Notifications
You must be signed in to change notification settings - Fork 408
[CELEBORN-2240] Adapt to SPARK-51756 which add a new parameter checksumValue in MapStatus.apply
#3570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| private static final DynMethods.BoundMethod MAP_STATUS_APPLY_METHOD = | ||
| DynMethods.builder("apply") | ||
| // for SPARK-51756 (4.1.0) and later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPARK-54663 or SPARK-51756
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about add the PR title as well, the new field is checksumValue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, seems the author changes the JIRA ticket in the PR title after merging -
- the git commit history is SPARK-51756
- the final PR title is changed to SPARK-54663
not a big deal, since SPARK-54663 is a sub-task of SPARK-51756.
checksumValue in MapStatus.apply
|
thanks, merged to main for 0.7.0 |
…sumValue` in `MapStatus.apply` Adapt to SPARK-51756, which changes the MapStatus API used by Celeborn. A necessary step to make Celeborn support Spark 4.1. No. Yes, it makes Have integrated with Spark 4.1 in the internal test env, and verified by some simple queries. Closes apache#3570 from pan3793/CELEBORN-2240. Authored-by: Cheng Pan <[email protected]> Signed-off-by: Cheng Pan <[email protected]>
What changes were proposed in this pull request?
Adapt to SPARK-51756, which changes the MapStatus API used by Celeborn.
Why are the changes needed?
A necessary step to make Celeborn support Spark 4.1.
Does this PR resolve a correctness bug?
No.
Does this PR introduce any user-facing change?
Yes, it makes
How was this patch tested?
Have integrated with Spark 4.1 in the internal test env, and verified by some simple queries.