-
Notifications
You must be signed in to change notification settings - Fork 408
[CELEBORN-2185] Support native kqueue transport on BSD/MacOS #3518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Code change LGTM, could you check the packaging side? IIRC, we excluded kqueue libs from the shaded client jars. |
pan3793
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only a nits.
But it's better to have a manual test (package the shaded client and run a real Spark/Flink jobs, on macOS) before getting in.
1571364 to
dc6ea1d
Compare
|
@pan3793, thanks for review. I have verified the packaging via |
dc6ea1d to
ed8d34a
Compare
ed8d34a to
25097d7
Compare
|
Ping @cxzl25. |
|
Merged to main(v0.7.0). |
@SteNicholas kqueue has also been excluded in the sbt build, so the sbt configuration should be updated accordingly. |
What changes were proposed in this pull request?
Support native kqueue transport on BSD/MacOS for
celeborn.<module>.io.mode.Backport:
AUTOIO Mode spark#52724Why are the changes needed?
Netty provides the following platform specific JNI transports for native transports:
These JNI transports add features specific to a particular platform, generate less garbage, and generally improve performance when compared to the NIO based transport.
Does this PR introduce any user-facing change?
Change the default value of
celeborn.<module>.io.modefromNIOtoEPOLLif epoll mode is available, fromNIOtoKQUEUEif kqueue mode is available, falling back toNIOotherwise.How was this patch tested?
CI.