Skip to content

Conversation

@leixm
Copy link
Contributor

@leixm leixm commented Jun 11, 2025

What changes were proposed in this pull request?

Rename throwsFetchFailure to stageRerunEnabled

Why are the changes needed?

Make the code cleaner.

Does this PR introduce any user-facing change?

Yes.

How was this patch tested?

existing UTs.

@leixm
Copy link
Contributor Author

leixm commented Jun 11, 2025

Copy link
Contributor

@AngersZhuuuu AngersZhuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SteNicholas SteNicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@AngersZhuuuu AngersZhuuuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SteNicholas pushed a commit that referenced this pull request Jun 11, 2025
### What changes were proposed in this pull request?
Rename throwsFetchFailure to stageRerunEnabled

### Why are the changes needed?
Make the code cleaner.

### Does this PR introduce _any_ user-facing change?
Yes.

### How was this patch tested?
existing UTs.

Closes #3324 from leixm/CELEBORN-2035.

Authored-by: Xianming Lei <[email protected]>
Signed-off-by: SteNicholas <[email protected]>
(cherry picked from commit edeeb4b)
Signed-off-by: SteNicholas <[email protected]>
@SteNicholas
Copy link
Member

Thanks. Merged to main(v0.7.0) and branch-0.6(v0.6.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants