[CELEBORN-1856][FOLLOWUP] Check isCelebornSkewedShuffle before registerCelebornSkewedShuffle for stage rollback
#3209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
force-pushed
the
spark_celeborn_patch
branch
from
6fcf09a to
afcd9a5
Compare
turboFei
changed the title
turboFei
changed the title
isCelebornSkewedShuffle before registerCelebornSkewedShuffle for stage rollback
Member
Author
turboFei
changed the title
isCelebornSkewedShuffle before registerCelebornSkewedShuffle for stage rollbackisCelebornShuffleIndeterminate before registerCelebornSkewedShuffle for stage rollback
turboFei
changed the title
isCelebornShuffleIndeterminate before registerCelebornSkewedShuffle for stage rollbackisCelebornSkewedShuffle before registerCelebornSkewedShuffle for stage rollback
Contributor
|
LGTM |
Member
Author
|
thanks all, merged to main(0.6.0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Followup for #3118
Add a condition check(isCelebornShuffleIndeterminate) before
registerCelebornSkewedShufflefor stage rollback.Why are the changes needed?
Fix the logical.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Minor change.