[CELEBORN-1560] Remove usages of deprecated Files.createTempDir of Guava#2680
Closed
bowenliang123 wants to merge 1 commit intoapache:mainfrom
Closed
[CELEBORN-1560] Remove usages of deprecated Files.createTempDir of Guava#2680bowenliang123 wants to merge 1 commit intoapache:mainfrom
bowenliang123 wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
Author
|
Similar PR in Trino. trinodb/trino#10313 |
RexXiong
approved these changes
Aug 26, 2024
Contributor
|
Merge to main(v0.6.0) |
wankunde
pushed a commit
to wankunde/celeborn
that referenced
this pull request
Oct 11, 2024
### What changes were proposed in this pull request? ### Why are the changes needed? `com.google.common.io.Files#createTempDir` has been deprecated since long ago. `java.nio.file.Files#createTempDirectory` should be used instead, as suggested in Guava's API Javadoc. (https://guava.dev/releases/33.1.0-jre/api/docs/com/google/common/io/Files.html) ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Closes apache#2680 from bowenliang123/files-temp-dir. Authored-by: Bowen Liang <liangbowen@gf.com.cn> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
com.google.common.io.Files#createTempDirhas been deprecated since long ago.java.nio.file.Files#createTempDirectoryshould be used instead, as suggested in Guava's API Javadoc. (https://guava.dev/releases/33.1.0-jre/api/docs/com/google/common/io/Files.html)Does this PR introduce any user-facing change?
How was this patch tested?