[CELEBORN-1389] Bump Dropwizard version from 3.2.6 to 4.2.25 #2540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteNicholas
force-pushed
the
CELEBORN-1389
branch
3 times, most recently
from
5910001 to
0c63c4d
Compare
Member
Author
|
Ping @pan3793, @onebox-li, @FMX. |
Member
|
Have you verified the Grafana Dashboard? |
Member
Author
|
@pan3793, I have not verified the dashboard changes because I did not use the dashboard in production environment. I only verified the dashboard display via https://stenicholas.grafana.net/goto/4ywHh1ySg?orgId=1. |
SteNicholas
force-pushed
the
CELEBORN-1389
branch
from
90605d7 to
0afa722
Compare
onebox-li
approved these changes
Jun 4, 2024
Contributor
onebox-li
left a comment
onebox-li
left a comment
There was a problem hiding this comment.
Thanks for mention, the grafana dashboard looks fine to me.
Member
Author
@pan3793, PTAL. |
FMX
approved these changes
Jun 4, 2024
Contributor
FMX
left a comment
FMX
left a comment
There was a problem hiding this comment.
LGTM. Merge into main(v0.6.0) and branch-0.5.
FMX
pushed a commit
that referenced
this pull request
Jun 4, 2024
### What changes were proposed in this pull request? Bump Dropwizard version from 3.2.6 to 4.2.25. Meanwhile, introduce `metrics_jvm_thread_peak_count_Value` and `metrics_jvm_thread_total_started_count_Value` in `celeborn-jvm-dashboard.json`. ### Why are the changes needed? Dropwizard metrics has released v4.2.25 including some bugfixes and improvements including: * [JVM] Fix maximum/total memory calculation: dropwizard/metrics#3125 * [Thread] Add peak and total started thread count to `ThreadStatesGaugeSet`: dropwizard/metrics#1601 Meanwhile, Ratis version has upgraded to 3.0.1 which has no compatibility problem with Dropwizard 4.2.25. Backport: - apache/spark#26332 - apache/spark#29426 - apache/spark#37372 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manual test. Closes #2540 from SteNicholas/CELEBORN-1389. Authored-by: SteNicholas <[email protected]> Signed-off-by: mingji <[email protected]> (cherry picked from commit 4fc42d7) Signed-off-by: mingji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Bump Dropwizard version from 3.2.6 to 4.2.25. Meanwhile, introduce
metrics_jvm_thread_peak_count_Valueandmetrics_jvm_thread_total_started_count_Valueinceleborn-jvm-dashboard.json.Why are the changes needed?
Dropwizard metrics has released v4.2.25 including some bugfixes and improvements including:
ThreadStatesGaugeSet: Add peak and total started thread count to ThreadStatesGaugeSet dropwizard/metrics#1601Meanwhile, Ratis version has upgraded to 3.0.1 which has no compatibility problem with Dropwizard 4.2.25.
Backport:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual test.