[CELEBORN-1391] Retry when MasterClient receiving a RpcTimeoutException #2466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waitinfuture
approved these changes
Apr 19, 2024
Contributor
waitinfuture
left a comment
waitinfuture
left a comment
There was a problem hiding this comment.
LGTM, thanks! Merging to main(v0.5.0)/branch-0.4(v0.4.1)
waitinfuture
pushed a commit
that referenced
this pull request
Apr 19, 2024
### What changes were proposed in this pull request? Retry when MasterClient receiving a RpcTimeoutException ### Why are the changes needed? When the MasterClient encounters an RpcTimeoutException, it may indicate that the current master is either busy or unavailable. In such cases, retrying with an alternative master endpoint could work. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test: org.apache.celeborn.common.client.MasterClientSuiteJ#testOneMasterTimeoutInHA Closes #2466 from jiang13021/celeborn-1391. Authored-by: jiang13021 <jiangyanze.jyz@antgroup.com> Signed-off-by: zky.zhoukeyong <zky.zhoukeyong@alibaba-inc.com> (cherry picked from commit d6fe6f2) Signed-off-by: zky.zhoukeyong <zky.zhoukeyong@alibaba-inc.com>
SteNicholas
pushed a commit
that referenced
this pull request
Apr 23, 2024
### What changes were proposed in this pull request? Retry when MasterClient receiving a RpcTimeoutException ### Why are the changes needed? When the MasterClient encounters an RpcTimeoutException, it may indicate that the current master is either busy or unavailable. In such cases, retrying with an alternative master endpoint could work. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test: org.apache.celeborn.common.client.MasterClientSuiteJ#testOneMasterTimeoutInHA Closes #2466 from jiang13021/celeborn-1391. Authored-by: jiang13021 <jiangyanze.jyz@antgroup.com> Signed-off-by: zky.zhoukeyong <zky.zhoukeyong@alibaba-inc.com>
SteNicholas
pushed a commit
that referenced
this pull request
Apr 23, 2024
### What changes were proposed in this pull request? Fix MasterClient construct method use in MasterClientSuiteJ. ### Why are the changes needed? MasterClient's construct method has changed by #2281 on main. It's a feature to support authentication on branch-0.5. #2466 's backport on branch-0.4 here caused a conflict in MasterClientSuiteJ.java:319. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Local compile test. Closes #2475 from onebox-li/branch-0.4-fix-compile. Authored-by: onebox-li <lyh-36@163.com> Signed-off-by: SteNicholas <programgeek@163.com>
cfmcgrady
pushed a commit
to cfmcgrady/incubator-celeborn
that referenced
this pull request
Aug 21, 2025
### What changes were proposed in this pull request? Retry when MasterClient receiving a RpcTimeoutException ### Why are the changes needed? When the MasterClient encounters an RpcTimeoutException, it may indicate that the current master is either busy or unavailable. In such cases, retrying with an alternative master endpoint could work. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test: org.apache.celeborn.common.client.MasterClientSuiteJ#testOneMasterTimeoutInHA Closes apache#2466 from jiang13021/celeborn-1391. Authored-by: jiang13021 <jiangyanze.jyz@antgroup.com> Signed-off-by: zky.zhoukeyong <zky.zhoukeyong@alibaba-inc.com>
cfmcgrady
pushed a commit
to cfmcgrady/incubator-celeborn
that referenced
this pull request
Aug 21, 2025
### What changes were proposed in this pull request? Fix MasterClient construct method use in MasterClientSuiteJ. ### Why are the changes needed? MasterClient's construct method has changed by apache#2281 on main. It's a feature to support authentication on branch-0.5. apache#2466 's backport on branch-0.4 here caused a conflict in MasterClientSuiteJ.java:319. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Local compile test. Closes apache#2475 from onebox-li/branch-0.4-fix-compile. Authored-by: onebox-li <lyh-36@163.com> Signed-off-by: SteNicholas <programgeek@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Retry when MasterClient receiving a RpcTimeoutException
Why are the changes needed?
When the MasterClient encounters an RpcTimeoutException, it may indicate that the current master is either busy or unavailable. In such cases, retrying with an alternative master endpoint could work.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test: org.apache.celeborn.common.client.MasterClientSuiteJ#testOneMasterTimeoutInHA