Skip to content

[CELEBORN-1315] Manually close the RocksDB/LevelDB instance when checkVersion throw Exception #2369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SteNicholas wants to merge 1 commit into from
Closed

[CELEBORN-1315] Manually close the RocksDB/LevelDB instance when checkVersion throw Exception #2369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...er/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/LevelDBProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,12 @@ public static org.iq80.leveldb.DB initLevelDB(File dbFile, StoreVersion version)
}
}
// if there is a version mismatch, we throw an exception, which means the service is unusable
checkVersion(tmpDb, version);
try {
checkVersion(tmpDb, version);
} catch (IOException ioe) {
tmpDb.close();
throw ioe;
}
}
return tmpDb;
}
Expand Down
4 changes: 4 additions & 0 deletions ...er/src/main/java/org/apache/celeborn/service/deploy/worker/shuffledb/RocksDBProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,11 @@ public static org.rocksdb.RocksDB initRockDB(File dbFile, StoreVersion version)
// is unusable
checkVersion(tmpDb, version);
} catch (RocksDBException e) {
tmpDb.close();
throw new IOException(e.getMessage(), e);
} catch (IOException ioe) {
tmpDb.close();
throw ioe;
}
}
return tmpDb;
Expand Down