-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CELEBORN-1125] Bump guava from 14.0.1 to 32.1.3-jre #2090
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2090 +/- ##
==========================================
- Coverage 46.77% 46.69% -0.07%
==========================================
Files 166 166
Lines 10695 10739 +44
Branches 977 981 +4
==========================================
+ Hits 5001 5014 +13
- Misses 5373 5404 +31
Partials 321 321
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
@@ -145,10 +146,10 @@ public long getLength() { | |||
|
|||
@Override | |||
public String toString() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before
FileSegmentManagedBuffer{file=/tmp/file, offset=1, length=1}
after
FileSegmentManagedBuffer[file=/tmp/file,offset=1,length=1]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is acceptable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Merged into main. |
ExclusionRule("org.checkerframework", "checker-qual"), | ||
ExclusionRule("org.codehaus.mojo", "animal-sniffer-annotations"), | ||
ExclusionRule("com.google.errorprone", "error_prone_annotations"), | ||
ExclusionRule("com.google.guava", "listenablefuture"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this one a runtime dep?
What changes were proposed in this pull request?
As title
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GA