Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1125] Bump guava from 14.0.1 to 32.1.3-jre #2090

Closed
wants to merge 7 commits into from

Conversation

cfmcgrady
Copy link
Contributor

@cfmcgrady cfmcgrady commented Nov 13, 2023

What changes were proposed in this pull request?

As title

Why are the changes needed?

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GA

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2090 (d4427c7) into main (eb1be3f) will decrease coverage by 0.07%.
Report is 3 commits behind head on main.
The diff coverage is 17.97%.

@@            Coverage Diff             @@
##             main    #2090      +/-   ##
==========================================
- Coverage   46.77%   46.69%   -0.07%     
==========================================
  Files         166      166              
  Lines       10695    10739      +44     
  Branches      977      981       +4     
==========================================
+ Hits         5001     5014      +13     
- Misses       5373     5404      +31     
  Partials      321      321              
Files Coverage Δ
...born/common/network/buffer/NettyManagedBuffer.java 63.16% <100.00%> (+4.34%) ⬆️
...leborn/common/network/buffer/NioManagedBuffer.java 83.34% <100.00%> (+3.34%) ⬆️
...e/celeborn/common/network/protocol/RpcRequest.java 69.57% <100.00%> (+9.57%) ⬆️
...born/common/network/protocol/StreamChunkSlice.java 88.38% <100.00%> (ø)
...ache/celeborn/common/network/protocol/Message.java 58.00% <0.00%> (ø)
...eleborn/common/network/client/TransportClient.java 43.58% <0.00%> (ø)
...orn/common/network/protocol/ChunkFetchRequest.java 0.00% <0.00%> (ø)
...ommon/network/buffer/FileSegmentManagedBuffer.java 31.04% <0.00%> (ø)
...orn/common/network/protocol/ChunkFetchFailure.java 19.05% <0.00%> (ø)
...orn/common/network/protocol/ChunkFetchSuccess.java 43.48% <0.00%> (ø)
... and 11 more

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@cfmcgrady cfmcgrady changed the title [CELEBORN-XXXX][WIP] Bump guava from 14.0.1 to 27.0-jre [CELEBORN-1125][WIP] Bump guava from 14.0.1 to 32.1.3-jre Nov 13, 2023
@cfmcgrady cfmcgrady changed the title [CELEBORN-1125][WIP] Bump guava from 14.0.1 to 32.1.3-jre [CELEBORN-1125] Bump guava from 14.0.1 to 32.1.3-jre Nov 13, 2023
@@ -145,10 +146,10 @@ public long getLength() {

@Override
public String toString() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before

FileSegmentManagedBuffer{file=/tmp/file, offset=1, length=1}

after

FileSegmentManagedBuffer[file=/tmp/file,offset=1,length=1]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is acceptable.

Copy link
Contributor

@FMX FMX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@FMX FMX closed this in aab073a Nov 21, 2023
@FMX
Copy link
Contributor

FMX commented Nov 21, 2023

Merged into main.

ExclusionRule("org.checkerframework", "checker-qual"),
ExclusionRule("org.codehaus.mojo", "animal-sniffer-annotations"),
ExclusionRule("com.google.errorprone", "error_prone_annotations"),
ExclusionRule("com.google.guava", "listenablefuture"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this one a runtime dep?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants