CASSSIDECAR-185: Adapt to cluster topology change for restore jobs #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yifan-c
force-pushed
the
CASSSIDECAR-185/trunk
branch
16 times, most recently
from
b67b265 to
a4dbcfa
Compare
yifan-c
commented
Jan 17, 2025
| @@ -59,7 +59,7 @@ jobs: | |||
| - install_common | |||
| - setup_remote_docker | |||
| - checkout | |||
| - run: ./gradlew build -x integrationTest --stacktrace | |||
| - run: ./gradlew javadoc && ./gradlew build -x integrationTest --stacktrace | |||
There was a problem hiding this comment.
run javadoc first to fail fast if there is doc formatting issue
yifan-c
commented
Jan 17, 2025
Comment on lines
-290
to
+292
| value="fall through|Fall through|fallthru|Fallthru|falls through|Falls through|fallthrough|Fallthrough|No break|NO break|no break|continue on" /> | ||
| value="fall through|Fall through|fallthru|Fallthru|falls through | ||
| |Falls through|fallthrough|Fallthrough|No break|NO break|no break | ||
| |continue on|no break by design" /> |
There was a problem hiding this comment.
break it down into multiple lines and add a new one "no break by design"
Patch by Yifan Cai; Reviewed by TBD for CASSSIDECAR-185
yifan-c
force-pushed
the
CASSSIDECAR-185/trunk
branch
from
a4dbcfa to
80340d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch by Yifan Cai; Reviewed by TBD for CASSSIDECAR-185