[CARBONDATA-4063] Refactor getBlockId and getShortBlockId functions #4026
Conversation
|
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4920/ |
|
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3165/ |
marchpure
force-pushed
the
blockid_codeclean
branch
from
7aff1ba to
3272c9e
Compare
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4931/ |
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3177/ |
marchpure
force-pushed
the
blockid_codeclean
branch
from
3272c9e to
ede2c54
Compare
|
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4934/ |
|
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3180/ |
marchpure
force-pushed
the
blockid_codeclean
branch
from
ede2c54 to
40d7077
Compare
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4938/ |
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3183/ |
marchpure
force-pushed
the
blockid_codeclean
branch
from
40d7077 to
61f7f07
Compare
|
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3187/ |
|
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4942/ |
marchpure
force-pushed
the
blockid_codeclean
branch
from
61f7f07 to
02e5d41
Compare
|
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4948/ |
|
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3193/ |
marchpure
force-pushed
the
blockid_codeclean
branch
from
02e5d41 to
7b98a82
Compare
|
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4953/ |
|
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3198/ |
marchpure
force-pushed
the
blockid_codeclean
branch
from
7b98a82 to
3f1838d
Compare
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3204/ |
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4959/ |
marchpure
force-pushed
the
blockid_codeclean
branch
from
3f1838d to
ef57e03
Compare
|
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3209/ |
|
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4964/ |
marchpure
force-pushed
the
blockid_codeclean
branch
from
ef57e03 to
83cebde
Compare
|
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3211/ |
|
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4966/ |
marchpure
force-pushed
the
blockid_codeclean
branch
from
83cebde to
0b19d45
Compare
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4967/ |
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3212/ |
marchpure
force-pushed
the
blockid_codeclean
branch
from
0b19d45 to
c0833af
Compare
|
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3217/ |
|
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4972/ |
marchpure
changed the title
marchpure
force-pushed
the
blockid_codeclean
branch
from
c0833af to
840a576
Compare
marchpure
changed the title
marchpure
changed the title
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4973/ |
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3218/ |
|
LGTM |
|
retest this please |
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5000/ |
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3245/ |
| } | ||
|
|
||
|
|
Why is this PR needed? Currently, getBlockId and getShortBlockId functions are too complex and unreadable, which can be more simpler and readable. What changes were proposed in this PR? Refactor the getBlockId and getShortBlockId functions without changing the blockid format and shortblockid format, There is no complatiability issue after the rafactoring. Does this PR introduce any user interface change? No Is any new testcase added? No
marchpure
force-pushed
the
blockid_codeclean
branch
from
840a576 to
2343d4b
Compare
|
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/5031/ |
|
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/3274/ |
Why is this PR needed?
Currently, getBlockId and getShortBlockId functions are too complex and unreadable, which can be more simpler and readable.
What changes were proposed in this PR?
Refactor the getBlockId and getShortBlockId functions without changing the blockid format and shortblockid format, There is no complatiability issue after the rafactoring.
Does this PR introduce any user interface change?
Is any new testcase added?