Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tearDown overload inherits @AfterEach instead of the declared @AfterAll #12163

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

Croway
Copy link
Contributor

@Croway Croway commented Nov 23, 2023

This is related to the following JUnit change junit-team/junit5#3498

@Croway Croway requested a review from oscerd November 23, 2023 09:41
Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@oscerd
Copy link
Contributor

oscerd commented Nov 23, 2023

/component-test azure

Result ✅ The tests passed successfully

@oscerd
Copy link
Contributor

oscerd commented Nov 23, 2023

Thanks @Croway

Copy link
Contributor

🤖 The Apache Camel test robot will run the tests for you 👍

@oscerd
Copy link
Contributor

oscerd commented Nov 23, 2023

Let's go.

@oscerd oscerd merged commit d4fee8a into apache:main Nov 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants