Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jms-ibmmq-client integration test native build runs on CI despite being commented out #5180

Closed
jamesnetherton opened this issue Aug 14, 2023 · 5 comments · Fixed by #5183
Closed
Assignees
Milestone

Comments

@jamesnetherton
Copy link
Contributor

Bug description

Not sure what's going on here. The native profile is commented out:

https://github.com/apache/camel-quarkus/blob/main/integration-tests/jms-ibmmq-client/pom.xml#L108-L136

But in the CI logs we see:

2023-08-14T11:11:27.1623572Z GraalVM Native Image: Generating 'camel-quarkus-integration-test-jms-ibmmq-client-3.0.0-SNAPSHOT-runner' (executable)...

Started happening with the Quarkus 3.2.4 upgrade. The only vaguely related thing in the release notes is:

quarkusio/quarkus#35203

@zhfeng
Copy link
Contributor

zhfeng commented Aug 15, 2023

Hmm, it's weird and I will take a look today.

@zhfeng
Copy link
Contributor

zhfeng commented Aug 15, 2023

It seems that the only way is to add <quarkus.build.skip>true</quarkus.build.skip> to skip quarkus build.

@zhfeng
Copy link
Contributor

zhfeng commented Aug 15, 2023

There is a related commit quarkusio/quarkus@3747c0d#diff-784b0a28679cfd7486e574f42e90ece03e187bae1e132d5c408f72eaa7ecfdf0

I wonder the if statement should check setPackageTypeSystemPropertyIfNativeProfileEnabled is true?

@zhfeng
Copy link
Contributor

zhfeng commented Aug 15, 2023

OK, the following change looks fixing our issue.

diff --git a/devtools/maven/src/main/java/io/quarkus/maven/BuildMojo.java b/devtools/maven/src/main/java/io/quarkus/maven/BuildMojo.java
index 0c7146ddb16..fefb7457970 100644
--- a/devtools/maven/src/main/java/io/quarkus/maven/BuildMojo.java
+++ b/devtools/maven/src/main/java/io/quarkus/maven/BuildMojo.java
@@ -118,7 +118,7 @@ protected void doExecute() throws MojoExecutionException {
             // Essentially what this does is to enable the native package type even if a different package type is set
             // in application properties. This is done to preserve what users expect to happen when
             // they execute "mvn package -Dnative" even if quarkus.package.type has been set in application.properties
-            if (!setPackageTypeSystemPropertyIfNativeProfileEnabled()) {
+            if (setPackageTypeSystemPropertyIfNativeProfileEnabled()) {
                 propertiesToClear.add(PACKAGE_TYPE_PROP);
             }

@zhfeng
Copy link
Contributor

zhfeng commented Aug 15, 2023

Anyway, I open the above quarkus issue to see if it can be fixed in upstream.

zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Aug 15, 2023
@github-actions github-actions bot added this to the 3.0.0 milestone Aug 15, 2023
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Sep 12, 2023
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Sep 12, 2023
jamesnetherton pushed a commit that referenced this issue Sep 12, 2023
jamesnetherton pushed a commit that referenced this issue Sep 12, 2023
@github-actions github-actions bot modified the milestones: 3.2.0, 3.3.0 Sep 12, 2023
zhfeng added a commit to zhfeng/camel-quarkus that referenced this issue Sep 18, 2023
zhfeng added a commit to jboss-fuse/camel-quarkus that referenced this issue Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants