-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade CRDs to apiextensions.k8s.io/v1 #1514
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently blocked by #1550. TODO:
|
Interface members are not supported by controller-tools that's used for generating CRDs. See kubernetes-sigs/controller-tools#126
Superseded by #1582. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1487. Camel K CRDs currently use
apiextensions.k8s.io/v1beta1
, which will be removed in future release of Kubernetes: kubernetes/kubernetes#82022.This PR enables the generation of the CRDs from the APIs, using the
controller-gen
CLI, which is part of the KubeBuilder project.The Operator SDK wraps it to provide a CLI to generate CRDs. However, it does not work for Camel K APIs, as these are packaged in their own module which is not the project root module.
It will be possible to leverage the features that come with
apiextensions.k8s.io/v1
, such as validation and defaulting.Last but not least, it brings OpenAPI structural schema, which also enables support for the
kubectl explain
sub-command for Camel K CRDs, e.g.:Release Note