-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI & Telemetry traits skipped for sourceless #5680
Comments
Thanks for reporting. Feel free to have a look if you can. We are tentatively going to add this before releasing 2.4 at the end of the month. Thanks. |
There is also a 3rd issue observed on 2.3.2. Scenario 3. When enabling both Telemetry and OpenAPI traits simultaneously. @hernanDatgDev were you able to observe the same behaviour on > 2.3.2? |
@gansheer I didn't realize you assigned this to yourself, I apologize. I've been looking at this and it seems that the |
Also it turns out that this regression doesn't actually have anything to do with the openApi trait and it's just a regression of the telemetry trait. When using the telemetry trait w/ a sourceless integration: |
What happened?
OpenAPI & Telemetry traits are not applied as expected when using sourceless integrations. This is believed to be a regression after a previous patch. The following are 2 scenarios describing use of these two traits with sourceless integrations as well as the versions of camel-k that were used for testing.
Scenario 1:
Run a sourceless integration with openApi and telemetry traits.
An application.properties file is created with relevant openAPI and telemetry fields
File is mounted in the pod
Works as expected in v2.2.0 and v2.3.0
Fails in v2.3.2, v2.3.3, v2.4.0-SNAPSHOT:
application.properties is mounted but only has openAPI fields, not the telemetry fields.
Scenario 2: (sourceless image refactored to include openAPI spec and openAPI trait not needed)
Run a sourceless integration with telemetry trait, not the openAPI trait
An application.properties file is created with relevant Telemetry fields
File is mounted in the pod
Works as expected in v2.2.0 and v2.3.0
Fails in v2.3.2, v2.3.3, v2.4.0-SNAPSHOT:
application.properties includes relevant Telemetry fields but is not mounted
Steps to reproduce
Described above ^
Relevant log output
No response
Camel K version
2.2.x, 2.3.x, 2.4.0-SNAPSHOT
The text was updated successfully, but these errors were encountered: