Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance environment trait to include values from secrets/configmaps #5522

Closed
squakez opened this issue May 17, 2024 · 2 comments · Fixed by #5754
Closed

Enhance environment trait to include values from secrets/configmaps #5522

squakez opened this issue May 17, 2024 · 2 comments · Fixed by #5754
Labels
area/traits good first issue Does not require full understanding of the codebase kind/feature New feature or request
Milestone

Comments

@squakez
Copy link
Contributor

squakez commented May 17, 2024

We can enhance the trait to include values taken directly from secret without the need to expose them or to mount as files via mount trait. For example we should have something like kamel run test.yaml -t env.vars=MY_VAR=secret:my-secret/my-value converted in a Pod like:

apiVersion: v1
kind: Pod
...
spec:
  containers:
...
    env:
    - name: MY_VAR
      valueFrom:
        secretKeyRef:
          name: my-secret
          key: my-value
@squakez squakez added kind/feature New feature or request good first issue Does not require full understanding of the codebase area/traits labels May 17, 2024
@tdiesler
Copy link
Contributor

sign me on

@squakez squakez added this to the 2.4.0 milestone Jun 13, 2024
tdiesler added a commit to tdiesler/camel-k that referenced this issue Jun 14, 2024
@tdiesler
Copy link
Contributor

PR: #5639

tdiesler added a commit to tdiesler/camel-k that referenced this issue Jun 17, 2024
tdiesler added a commit to tdiesler/camel-k that referenced this issue Jun 17, 2024
tdiesler added a commit to tdiesler/camel-k that referenced this issue Jun 17, 2024
tdiesler added a commit to tdiesler/camel-k that referenced this issue Jun 17, 2024
tdiesler added a commit to tdiesler/camel-k that referenced this issue Jun 18, 2024
tdiesler added a commit to tdiesler/camel-k that referenced this issue Jun 18, 2024
tdiesler added a commit to tdiesler/camel-k that referenced this issue Jun 19, 2024
@squakez squakez modified the milestones: 2.4.0, 2.5.0 Jul 30, 2024
squakez added a commit to squakez/camel-k that referenced this issue Aug 8, 2024
squakez added a commit to squakez/camel-k that referenced this issue Aug 13, 2024
squakez added a commit to squakez/camel-k that referenced this issue Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/traits good first issue Does not require full understanding of the codebase kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants