Add NonreflectableMessage and support Protobuf v5 #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasphin
force-pushed
the
feature/nonreflectable-message
branch
from
b3ff132 to
c8c6cc9
Compare
See apache#2722 (comment) inspired by unreflectable_message of @oathdruid.
wasphin
force-pushed
the
feature/nonreflectable-message
branch
from
c8c6cc9 to
807dc93
Compare
7 tasks
Closed
chenBright
reviewed
Oct 26, 2024
|
ci 问题看和改动无关，暂时没有 bazel 测试环境，得晚几天再看看 |
|
LGTM |
看起来[email protected]还是有点问题，PR预期[email protected]能修复；我先给这个发布到babylon的registry了，应该能先跑起来；等bcr的merge进去可以无缝替换 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2722 (comment) inspired by unreflectable_message of @oathdruid.
What problem does this PR solve?
Issue Number: #2757
Problem Summary:
隔离 Protobuf Message API，简化内部消息类型实现，简化后续 Protobuf 适配工作，支持 Protobuf 到 v5.28.0
What is changed and the side effects?
Changed:
Side effects:
Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):
Check List: