Fix zeppelin build on ppc64le - JIRA BIGTOP-3560 #813

afsanjar · 2021-08-24T20:35:15Z

https://issues.apache.org/jira/browse/BIGTOP-3560

sekikn · 2021-08-25T00:01:40Z

bigtop_toolchain/files/grpc-java-1.28.0-add-support-for-ppc64le.patch

+                     // Link other (system) libraries dynamically.
+                     // Clang under OSX doesn't support these options.
+                     linker.args "-Wl,-Bstatic", "-lprotoc", "-lprotobuf", "-static-libgcc",
+-                            "-static-libstdc++",


Instead of removing this, adding libstdc++-static to the packages to be installed seemed to resolve the compiling issue on CentOS 7.
sekikn@b94539c#diff-9337fb34935804ab7b56cd89ae94e14491ad4c64804daa9b1843eeec336772edR67

Not sure that would work on Ubuntu. But the fix is a backport of an upstream patch grpc/grpc-java#8141

sekikn · 2021-08-25T00:02:21Z

bigtop_toolchain/manifests/grpc.pp

+
+  exec { "build grpc-java ${grpc_version}":
+      cwd => "/usr/src/grpc-java-${grpc_version}",
+      command => "/usr/bin/patch -p1 < grpc-java-${grpc_version}-add-support-for-ppc64le.patch && export LDFLAGS=-L/${proto_home}/lib && export CXXFLAGS=-I/${proto_home}/include && export LD_LIBRARY_PATH=/${proto_home}/lib && cd compiler && ../gradlew java_pluginExecutable -PskipAndroid=true",


I think setting environment variables in the environment attribute is better for code simplicity.
sekikn@b94539c#diff-f2963d87c19d71d34863fb0039c7b3d3d0e3699b77bfd7bd57009ca568f51da6R78

Thanks, I am not a PP expert. My first time, I used https://github.com/apache/bigtop/blob/master/bigtop_toolchain/manifests/gradle.pp as a guide. Let me know if you need me to change it.

oh got it:
environment => ['CXXFLAGS=-I/usr/local/protobuf-3.5.1.1/include', 'LDFLAGS=-L/usr/local/protobuf-3.5.1.1/lib'],

Hi @sekikn, were you able to try to run the PR with all distros? If not, let me know. I'll try to do it over the weekend. Thanks

@afsanjar Sorry, I couldn't have enough time to do it. It's really helpful if you could try it on this weekend!

sekikn · 2021-08-25T00:06:26Z

Hi @afsanjar, thank you so much for working on this! I've also tried this issue, so let me share my findings in addition to the comments above.
(Just for reference, my patch is sekikn@b94539c. But I only made sure it worked with CentOS 7, so I'm going to try your PR with all distros instead)

In my environment, building the gRPC-Java compiler failed in the platform check. I had to add the following patch for avoiding it.
sekikn@b94539c#diff-3691792fac1b47949baafea0e89da9956fb028a702b366065c5eb22ba6d1fb66
Upgrading node and npm seemed to be needed on CentOS 7, because of the same problem as BIGTOP-3564. Fix build failure of Flink on Cent OS 7 ppc64le. #793.
sekikn@b94539c#diff-b04756af9f3626aa5a5a19e5fa0efe423f97f4ac810f9ac805c8cd23b13ff1fe
npm tries to install its packages under user's home directory, but its permission is set as 644 or something for the root user by default on some distros. So I had to set it writable.
sekikn@b94539c#diff-daf9d5db7e58dd630af913e1b218f196fad9523f90ab27352f48c92324d986d0R71-R72
In case of running the build as root, npm and bower seemed to require some additional options.
sekikn@b94539c#diff-b04756af9f3626aa5a5a19e5fa0efe423f97f4ac810f9ac805c8cd23b13ff1feR1335-R1336
sekikn@b94539c#diff-b04756af9f3626aa5a5a19e5fa0efe423f97f4ac810f9ac805c8cd23b13ff1feR1375-R1376

sekikn · 2021-09-15T12:04:11Z

@afsanjar I've just tried the current PR and found two problems.

I tried to create the Debian 10 image, but came across the following error. It seems that we have to ensure installing JDK precedes grpc-java.

jenkins@bigtop1slave:~/bigtop/docker/bigtop-slaves$ ./build.sh trunk-debian-10                                      

...

Step 4/6 : RUN if [ -f ~/.bash_profile ]; then . ~/.bash_profile; fi &&     apt-get clean && apt-get update &&     puppet apply -e "include bigtop_toolchain::installer" || if [ $? -ne 2 ]; then exit 1; fi                           
 ---> Running in 4b9c42c8296a                                                                                      
Hit:1 http://deb.debian.org/debian buster InRelease                                                                

...

Notice: /Stage[main]/Bigtop_toolchain::Grpc/Exec[download grpc-java 1.28.0]/returns: executed successfully
Notice: /Stage[main]/Bigtop_toolchain::Grpc/File[/usr/src/grpc-java-1.28.0/grpc-java-1.28.0-add-support-for-ppc64le.patch]/ensure: defined content as '{md5}a2fb2f8169fd1d1b1c973c2e6fb0bd1d'
Notice: /Stage[main]/Bigtop_toolchain::Grpc/Exec[build grpc-java 1.28.0]/returns: patching file compiler/build.gradle
Notice: /Stage[main]/Bigtop_toolchain::Grpc/Exec[build grpc-java 1.28.0]/returns: 
Notice: /Stage[main]/Bigtop_toolchain::Grpc/Exec[build grpc-java 1.28.0]/returns: ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
Notice: /Stage[main]/Bigtop_toolchain::Grpc/Exec[build grpc-java 1.28.0]/returns: 
Notice: /Stage[main]/Bigtop_toolchain::Grpc/Exec[build grpc-java 1.28.0]/returns: Please set the JAVA_HOME variable in your environment to match the
Notice: /Stage[main]/Bigtop_toolchain::Grpc/Exec[build grpc-java 1.28.0]/returns: location of your Java installation.
Error: '/usr/bin/patch -p1 < grpc-java-1.28.0-add-support-for-ppc64le.patch && export LDFLAGS=-L//usr/local/protobuf-3.5.1.1/lib && export CXXFLAGS=-I//usr/local/protobuf-3.5.1.1/include && export LD_LIBRARY_PATH=//usr/local/protob
uf-3.5.1.1/lib && cd compiler && ../gradlew java_pluginExecutable -PskipAndroid=true' returned 1 instead of one of [0]
Error: /Stage[main]/Bigtop_toolchain::Grpc/Exec[build grpc-java 1.28.0]/returns: change from 'notrun' to ['0'] failed: '/usr/bin/patch -p1 < grpc-java-1.28.0-add-support-for-ppc64le.patch && export LDFLAGS=-L//usr/local/protobuf-3.
5.1.1/lib && export CXXFLAGS=-I//usr/local/protobuf-3.5.1.1/include && export LD_LIBRARY_PATH=//usr/local/protobuf-3.5.1.1/lib && cd compiler && ../gradlew java_pluginExecutable -PskipAndroid=true' returned 1 instead of one of [0]

...

Notice: /Stage[main]/Apt/Apt::Setting[conf-update-stamp]/File[/etc/apt/apt.conf.d/15update-stamp]/ensure: defined content as '{md5}0962d70c4ec78bbfa6f3544ae0c41974'
Notice: /Stage[main]/Bigtop_toolchain::Jdk/Apt::Source[adoptopenjdk]/Apt::Key[Add key: 8ED17AF5D7E675EB3EE3BCE98AC3B29174885C03 from Apt::Source adoptopenjdk]/Apt_key[Add key: 8ED17AF5D7E675EB3EE3BCE98AC3B29174885C03 from Apt::Source adoptopenjdk]/ensure: created
Notice: /Stage[main]/Bigtop_toolchain::Jdk/Apt::Source[adoptopenjdk]/Apt::Setting[list-adoptopenjdk]/File[/etc/apt/sources.list.d/adoptopenjdk.list]/ensure: defined content as '{md5}838e14e546e87e023031dc31717d86e9'
Notice: /Stage[main]/Apt::Update/Exec[apt_update]: Triggered 'refresh' from 1 event
Notice: /Stage[main]/Bigtop_toolchain::Jdk/Package[adoptopenjdk-8-hotspot]/ensure: created
Notice: /Stage[last]/Bigtop_toolchain::Cleanup/Exec[remove archives]: Dependency Exec[build grpc-java 1.28.0] has failures: true
Warning: /Stage[last]/Bigtop_toolchain::Cleanup/Exec[remove archives]: Skipping because of failed dependencies
Warning: /Stage[last]/Bigtop_toolchain::Cleanup/Exec[clean packages]: Skipping because of failed dependencies
Notice: Applied catalog in 5591.91 seconds

The CentOS 7 image was successfully built, but I got the following error when building Zeppelin with it. This should be fixed by upgrading node and npm as I mentioned above.

jenkins@bigtop1slave:~/bigtop$ docker run -it -v $PWD:/bigtop bigtop/slaves:trunk-centos-7-ppc64le 
[root@23fed65f4b12 /]# cd bigtop
[root@23fed65f4b12 bigtop]# ./gradlew allclean zeppelin-pkg repo

...

[INFO] --- frontend-maven-plugin:1.6:npm (npm install) @ zeppelin-web ---                                                                                                                                                     [61/1976]
[INFO] Running 'npm install --no-lockfile' in /bigtop/build/zeppelin/rpm/BUILD/zeppelin-0.9.0/zeppelin-web
[ERROR] /bigtop/build/zeppelin/rpm/BUILD/zeppelin-0.9.0/zeppelin-web/node/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /bigtop/build/zeppelin/rpm/BUILD/zeppelin-0.9.0/zeppelin-web/node/node)
[ERROR] /bigtop/build/zeppelin/rpm/BUILD/zeppelin-0.9.0/zeppelin-web/node/node: /lib64/libstdc++.so.6: version `CXXABI_1.3.9' not found (required by /bigtop/build/zeppelin/rpm/BUILD/zeppelin-0.9.0/zeppelin-web/node/node)
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Zeppelin 0.9.0:                                                                         
[INFO]                                                                                                             
[INFO] Zeppelin ........................................... SUCCESS [ 18.555 s]

...

[INFO] Zeppelin: Client Examples .......................... SUCCESS [  1.790 s]
[INFO] Zeppelin: web Application .......................... FAILURE [  7.872 s]

...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  09:58 min
[INFO] Finished at: 2021-09-15T08:54:42Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.6:npm (npm install) on project zeppelin-web: Failed to run task: 'npm install --no-lockfile' failed. org.apache.commons.exec.ExecuteException: Process exite
d with an error: 1 (Exit value: 1) -> [Help 1]

Without the problems above, I succeeded in building Zeppelin on CentOS 8. Would you update the PR?

sekikn · 2021-09-15T13:17:25Z

Or, if it's OK with you, I can merge the current PR since it works with CentOS 8 (and probably all of other distros except for CentOS 7 and Debian 10) and address the remaining issues as follow-up.

afsanjar · 2021-09-15T18:11:10Z

Hi @sekikn, I fixed those issues (i.e., debain10 with JAVA_HOME issue) last weekend and merged your fixes zeppelin-web (i.e., root-access ). But have been swapped. I'll merge the fixes this weekend, is that okay?

afsanjar · 2021-09-15T19:59:34Z

done

sekikn · 2021-09-17T15:47:48Z

Great, thanks for the update! I confirmed the Debian 10 problem was fixed with the latest commit.

I think the CentOS 7 issue still remains, right? Would you add that commit to the PR too?
Just adding the following lines to the ppc64-specific section in do-component-build should work, just like #793.

sed -i "s|<node.version>v12.3.1</node.version>|<node.version>v12.22.1</node.version>|" pom.xml
sed -i "s|<npm.version>6.9.0</npm.version>|<npm.version>6.14.12</npm.version>|" pom.xml

afsanjar · 2021-09-19T11:28:50Z

done

sekikn · 2021-09-19T14:16:34Z

+1, confirmed the build on CentOS 7 also succeeded. Thanks a lot @afsanjar!

(cherry picked from commit 84da675)

sekikn · 2021-09-19T14:28:35Z

Merged into branch-3.0 and master.

afsanjar · 2021-09-20T11:23:17Z

thanks @sekikn . you did most of the work :)

Amir Sanjar and others added 5 commits July 15, 2021 20:42

adding ppc64le support for kibana

8216943

Merge branch 'apache:master' into master

5a2f60c

Merge branch 'apache:master' into master

6e31066

fixzeppelin on ppc64le - JIRA BIGTOP-3560

5a27344

Update .travis.yml

1e75078

sekikn reviewed Aug 25, 2021

View reviewed changes

Merge branch 'apache:master' into master

a0f736f

BIGTOP-3560 part 2

305f61d

Fixing centos 7 build break based on BIGTOP-3564.

e7980ee

sekikn merged commit 84da675 into apache:master Sep 19, 2021

sekikn pushed a commit that referenced this pull request Sep 19, 2021

Fix zeppelin build on ppc64le - JIRA BIGTOP-3560 (#813)

241a7b6

(cherry picked from commit 84da675)

iwasakims mentioned this pull request Feb 16, 2022

BIGTOP-3639: Alluxio build fails on ppc64le #861

Merged

Fix zeppelin build on ppc64le - JIRA BIGTOP-3560 #813

Fix zeppelin build on ppc64le - JIRA BIGTOP-3560 #813

Uh oh!

Conversation

afsanjar commented Aug 24, 2021

Uh oh!

sekikn Aug 25, 2021

Choose a reason for hiding this comment

Uh oh!

afsanjar Aug 25, 2021

Choose a reason for hiding this comment

Uh oh!

sekikn Aug 25, 2021

Choose a reason for hiding this comment

Uh oh!

afsanjar Aug 25, 2021

Choose a reason for hiding this comment

Uh oh!

afsanjar Aug 25, 2021

Choose a reason for hiding this comment

Uh oh!

afsanjar Sep 10, 2021

Choose a reason for hiding this comment

Uh oh!

sekikn Sep 11, 2021

Choose a reason for hiding this comment

Uh oh!

sekikn commented Aug 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sekikn commented Sep 15, 2021

Uh oh!

sekikn commented Sep 15, 2021

Uh oh!

afsanjar commented Sep 15, 2021

Uh oh!

afsanjar commented Sep 15, 2021

Uh oh!

sekikn commented Sep 17, 2021

Uh oh!

afsanjar commented Sep 19, 2021

Uh oh!

sekikn commented Sep 19, 2021

Uh oh!

sekikn commented Sep 19, 2021

Uh oh!

afsanjar commented Sep 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sekikn commented Aug 25, 2021 •

edited

Loading