[Java] Change precondition checks to use lazy formatting

[scwhittle]

Just fixed up ones I found based upon simple regexp searching.

Motivated by https://github.com/apache/beam/pull/36063/files which ended up being very expensive. Some of these others could be as well and just not noticed. Separate from https://github.com/apache/beam/pull/36063/files in case we want to cherrypick that one.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @scwhittle, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the performance and resource efficiency of the Apache Beam Java codebase. It achieves this by refactoring how error messages are constructed within precondition checks (like checkArgument, checkNotNull, and checkState). Instead of concatenating strings, which can be costly, the messages now use lazy formatting, ensuring that string construction only occurs when an assertion fails. This systematic change, applied across various modules, aims to reduce overhead and improve overall application performance.

Highlights

• Performance Optimization for Precondition Checks: Updated numerous checkArgument, checkNotNull, and checkState calls across the codebase to utilize lazy string formatting (e.g., "%s") instead of eager string concatenation.
• Improved Resource Efficiency: This change prevents the unnecessary allocation and concatenation of strings when precondition checks pass, leading to potential performance and memory usage improvements, especially in hot code paths.
• Codebase Consistency: Standardized the approach to error message construction in precondition checks, aligning with best practices for efficient and readable code.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers