JCSMP properties providers for new SolaceIO write connector #31906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a base class and two providers for the new SolaceIO write connector. The basic authentication provider just uses a username and password. Users can write their own providers to set authentication mechanisms and other session properties, by extending from the base class. As an example, we provide a GoogleCloudSecretProvider, to show how to create your own. This provider can also be used "as is", but it is mainly meant as an example to implement your own. In upcoming PRs, I will be submitting the rest of the write connector. It is thousands of lines of code, so I am splitting in smaller PRs, to facilitate code reviews. This PR contributes to apache#31905
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
Author
|
assign set of reviewers |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Abacn
reviewed
Jul 19, 2024
Contributor
Abacn
left a comment
Abacn
left a comment
There was a problem hiding this comment.
Thanks. I notice that this change may overlap with existing BasicAuthJcsmpSessionServiceFactory currently used for read transform. Consider make it fit with both read and write transform? So user have consistent way to configure read and write IO
...rc/main/java/org/apache/beam/sdk/io/solace/write/properties/BasicAuthenticationProvider.java
Outdated
Show resolved
Hide resolved
Abacn
reviewed
Jul 22, 2024
| * | ||
| * <h2>Writing</h2> | ||
| * | ||
| * TBD |
Contributor
There was a problem hiding this comment.
note - public facing doc. subjected to update before next release cut
iht
added a commit
to iht/beam
that referenced
this pull request
Jul 23, 2024
…1905 This adds the interface of the Write connector and a few classes (data classes, POutput) that are used by the connector.
iht
added a commit
to iht/beam
that referenced
this pull request
Jul 23, 2024
…1905 This adds the interface of the Write connector and a few classes (data classes, POutput) that are used by the connector.
Abacn
pushed a commit
that referenced
this pull request
Jul 29, 2024
This adds the interface of the Write connector and a few classes (data classes, POutput) that are used by the connector.
reeba212
pushed a commit
to reeba212/beam
that referenced
this pull request
Dec 4, 2024
…1906) * JCSMP properties providers for new SolaceIO write connector This adds a base class and two providers for the new SolaceIO write connector. The basic authentication provider just uses a username and password. Users can write their own providers to set authentication mechanisms and other session properties, by extending from the base class. As an example, we provide a GoogleCloudSecretProvider, to show how to create your own. This provider can also be used "as is", but it is mainly meant as an example to implement your own. In upcoming PRs, I will be submitting the rest of the write connector. It is thousands of lines of code, so I am splitting in smaller PRs, to facilitate code reviews. This PR contributes to apache#31905 * Fix CheckStyle and Spotbugs errors * Fix class dependencies declaration * Unify session and auth providers/factories for the read and write connectors * Fix format violations in comment
reeba212
pushed a commit
to reeba212/beam
that referenced
this pull request
Dec 4, 2024
…1905 (apache#31953) This adds the interface of the Write connector and a few classes (data classes, POutput) that are used by the connector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a base class and two providers for the new SolaceIO write connector. The basic authentication provider just uses a username and password.
Users can write their own providers to set authentication mechanisms and other session properties, by extending from the base class. As an example, we provide a GoogleCloudSecretProvider, to show how to create your own. This provider can also be used "as is", but it is mainly meant as an example to implement your own.
In upcoming PRs, I will be submitting the rest of the write connector. It is thousands of lines of code, so I am splitting in smaller PRs, to facilitate code reviews.
All these PRs are part of the SolaceIO Write feature request #31905
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.