Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Snowflake escape char to backslash #31779

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

turb
Copy link
Contributor

@turb turb commented Jul 4, 2024

Set Snowflake escape char to backslash since it is the default used by CSVParser (fixes #24467).

One improvement would be to have this as configuration, but the change would be quite important.

It does not fix a related problem: it fails in some cases with \n in the data.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Contributor

github-actions bot commented Jul 4, 2024

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label java.
R: @damondouglas for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damondouglas damondouglas merged commit 02600f5 into apache:master Jul 8, 2024
18 checks passed
@damondouglas
Copy link
Contributor

Thank you @turb for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: SnowflakeIO does not escape quote characters
2 participants