-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert Flink 1.18 support #31274
Revert Flink 1.18 support #31274
Conversation
|
Running a Nightly Snapshot on this branch: https://github.com/apache/beam/actions/runs/9068716106 then will run a PostRelease test to see if revert two PRs will fix PostRelease test Update: PostRelease test using modified Nightly Snapshot (reverted #31062) passed: https://github.com/apache/beam/actions/runs/9069100546/job/24917900959 |
This reverts commit 5ff55b1.
I have cleaned up this test PR and ready for review |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
LGTM once all testing is passed. |
Also adding @thebozzcl and @je-ik for awareness. |
Run Python_Coverage PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though as you mentioned, this probably will not resolve the issue, but at least we can be sure.
This exposes a separate issue that Flink 1.18 class (presumably the highest supported one) is used when running the Flink 1.17 QuickStart test. This makes the test now failing in both 1.18 and 1.17 version and confused us |
The test entry is here: https://github.com/apache/beam/blob/master/release/src/main/groovy/quickstart-java-flinklocal.groovy One can see the invocation only has "--runner=FlinkRunner -Pflink-runner" parameter. The first tells beam to use Flink runner, the second tells maven to activate flink related java dependencies, which pinned to "project.ext.latestFlinkVersion":
|
Two possible way to fix
|
The check passes on current master. After reverting this PR the test for Flink 1.18 pass locally. I'm not familiar with the mechanics how the test is executed, though. It uses maven, but I'm unable to get the |
Revert #31062 and #31217 (partially), reason - breaks PostRelease test suite.
Tested that revert these two PR, Failed Flink validation task in PostRelease back green
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.