Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Flink 1.18 support #31274

Merged
merged 3 commits into from
May 14, 2024
Merged

Revert Flink 1.18 support #31274

merged 3 commits into from
May 14, 2024

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented May 13, 2024

Revert #31062 and #31217 (partially), reason - breaks PostRelease test suite.

Tested that revert these two PR, Failed Flink validation task in PostRelease back green

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@github-actions github-actions bot added the build label May 13, 2024
@Abacn
Copy link
Contributor Author

Abacn commented May 13, 2024

./gradlew :runners:flink:1.17:runQuickstartJavaFlinkLocal now also failing: https://github.com/apache/beam/actions/runs/9068053305/job/24914468708

@Abacn
Copy link
Contributor Author

Abacn commented May 13, 2024

Running a Nightly Snapshot on this branch: https://github.com/apache/beam/actions/runs/9068716106

then will run a PostRelease test to see if revert two PRs will fix PostRelease test

Update: PostRelease test using modified Nightly Snapshot (reverted #31062) passed: https://github.com/apache/beam/actions/runs/9069100546/job/24917900959

@Abacn Abacn changed the title [Test only] Run validation on Flink 1.17 Revert Flink 1.18 support May 13, 2024
@Abacn
Copy link
Contributor Author

Abacn commented May 13, 2024

I have cleaned up this test PR and ready for review

@Abacn Abacn marked this pull request as ready for review May 13, 2024 20:33
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@shunping
Copy link
Contributor

LGTM once all testing is passed.

@shunping
Copy link
Contributor

Also adding @thebozzcl and @je-ik for awareness.

@shunping
Copy link
Contributor

Run Python_Coverage PreCommit

Copy link
Contributor

Test Results

0 files   -    10  0 suites   - 10   0s ⏱️ - 23m 15s
0 tests  - 7 539  0 ✅  - 6 641  0 💤  -   898  0 ❌ ±0 
0 runs   - 7 737  0 ✅  - 6 670  0 💤  - 1 067  0 ❌ ±0 

Results for commit 0542c83. ± Comparison against base commit c230655.

Copy link
Contributor

@je-ik je-ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though as you mentioned, this probably will not resolve the issue, but at least we can be sure.

@Abacn
Copy link
Contributor Author

Abacn commented May 14, 2024

This exposes a separate issue that Flink 1.18 class (presumably the highest supported one) is used when running the Flink 1.17 QuickStart test. This makes the test now failing in both 1.18 and 1.17 version and confused us

@Abacn Abacn merged commit bcac88b into master May 14, 2024
107 of 109 checks passed
@Abacn Abacn deleted the debugpostrelease branch May 14, 2024 15:01
@Abacn
Copy link
Contributor Author

Abacn commented May 14, 2024

The test entry is here: https://github.com/apache/beam/blob/master/release/src/main/groovy/quickstart-java-flinklocal.groovy

One can see the invocation only has "--runner=FlinkRunner -Pflink-runner" parameter. The first tells beam to use Flink runner, the second tells maven to activate flink related java dependencies, which pinned to "project.ext.latestFlinkVersion":

'flink.artifact.name': 'beam-runners-flink-'.concat(project(":runners:flink:${project.ext.latestFlinkVersion}").getName()),

@Abacn
Copy link
Contributor Author

Abacn commented May 14, 2024

Two possible way to fix

  • Move createJavaExamplesArchetypeValidationTask from flink_runner.gradle to runners/flink/build.gradle, so a single validation task run on latest supported flink

  • make createJavaExamplesArchetypeValidationTask aware of flink version, pass it down to maven-archetype project, and set version there

@je-ik
Copy link
Contributor

je-ik commented May 17, 2024

The check passes on current master. After reverting this PR the test for Flink 1.18 pass locally. I'm not familiar with the mechanics how the test is executed, though. It uses maven, but I'm unable to get the pom.xml used to execute the test to compare it for differences with 1.17. Any clues anyone?

@je-ik
Copy link
Contributor

je-ik commented May 17, 2024

#31328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants