-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Add feast feature store handler for enrichment transform #30957
Conversation
c8d1a00
to
20eada9
Compare
20eada9
to
29ee274
Compare
6fc27b3
to
7be053f
Compare
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @liferoad for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Friendly ping! |
R: @damccorm |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks pretty good, had a few comments
sdks/python/apache_beam/transforms/enrichment_handlers/feast_feature_store.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/transforms/enrichment_handlers/feast_feature_store.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/transforms/enrichment_handlers/feast_feature_store.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/transforms/enrichment_handlers/feast_feature_store.py
Outdated
Show resolved
Hide resolved
49bcc5e
to
86fbf15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just had one last small comment about the pydoc, otherwise LGTM
sdks/python/apache_beam/transforms/enrichment_handlers/feast_feature_store.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once checks pass - thanks!
Unrelated failures in postcommit with pytorch and tensorflow. Merging this one! |
Implement Feast feature store handler for enrichment transform. To setup the feast repository for GCP, see this notebook.
Example usage:
Fixes #30964
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.