Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable profiling in cythonized code by default. #30938

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Disable profiling in cythonized code by default. #30938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53ae1ef
Remove Cython profiling.
tvalentyn Apr 11, 2024
9732e7f
Update CHANGES.md
tvalentyn Apr 12, 2024
fdbdd8c
Merge branch 'master' into cy_profile
tvalentyn Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@

## New Features / Improvements

* X feature added (Java/Python) ([#X](https://github.com/apache/beam/issues/X)).
* Profiling of Cythonized code has been disabled by default. This might improve performance for some Python pipelines ([#30938](https://github.com/apache/beam/pull/30938)).
* Bigtable enrichment handler now accepts a custom function to build a composite row key. (Python) ([#30974](https://github.com/apache/beam/issues/30975)).

## Breaking Changes
Expand Down
1 change: 0 additions & 1 deletion sdks/python/apache_beam/coders/coder_impl.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# limitations under the License.
#

# cython: profile=True

cimport cython

Expand Down
1 change: 0 additions & 1 deletion sdks/python/apache_beam/metrics/monitoring_infos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#

# cython: language_level=3
# cython: profile=True

# pytype: skip-file

Expand Down
1 change: 0 additions & 1 deletion sdks/python/apache_beam/runners/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
# cython: profile=True
# cython: language_level=3

"""Worker operations executor.
Expand Down
1 change: 0 additions & 1 deletion sdks/python/apache_beam/runners/worker/opcounters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#

# cython: language_level=3
# cython: profile=True

"""Counters collect the progress of the Worker for reporting to the service."""

Expand Down
1 change: 0 additions & 1 deletion sdks/python/apache_beam/runners/worker/operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
#

# cython: language_level=3
# cython: profile=True

"""Worker operations executor."""

Expand Down
1 change: 0 additions & 1 deletion sdks/python/apache_beam/runners/worker/statesampler_fast.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# limitations under the License.
#

# cython: profile=True
# cython: language_level=3

"""State sampler for tracking time spent in execution steps.
Expand Down
1 change: 0 additions & 1 deletion sdks/python/apache_beam/testing/fast_test_utils.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# limitations under the License.
#

# cython: profile=True

cimport libc.stdint

Expand Down
1 change: 0 additions & 1 deletion sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
# limitations under the License.
#

# cython: profile=True

""" For internal use only. No backwards compatibility guarantees."""

Expand Down
1 change: 0 additions & 1 deletion sdks/python/apache_beam/transforms/cy_dataflow_distribution_counter.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
# limitations under the License.
#

# cython: profile=True
# cython: language_level=3

""" For internal use only. No backwards compatibility guarantees."""
Expand Down
1 change: 0 additions & 1 deletion sdks/python/apache_beam/utils/counters.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# limitations under the License.
#

# cython: profile=True
# cython: overflowcheck=True

cdef class Counter(object):
Expand Down
1 change: 0 additions & 1 deletion sdks/python/apache_beam/utils/windowed_value.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
# editing this file as WindowedValues are created for every element for
# every step in a Beam pipeline.

# cython: profile=True
# cython: language_level=3

# pytype: skip-file
Expand Down
Loading