Add gradle target and github workflow for cross-langauge yaml tests. #30874
Conversation
This should have caught the issue at apache#30776
|
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
| - name: Setup environment | ||
| uses: ./.github/actions/setup-environment-action | ||
| with: | ||
| python-version: | |
There was a problem hiding this comment.
Do we actually need 2 python versions?
There was a problem hiding this comment.
I think we're just running against 3.11 here
There was a problem hiding this comment.
It looks like the gradle commands are using 3.8 by default. We probably don't need both.
| push: | ||
| tags: ['v*'] | ||
| branches: ['master', 'release-*'] | ||
| paths: [ "model/**","sdks/python/**","release/**",".github/workflows/beam_PreCommit_Yaml_Xlang_Direct.yml"] |
There was a problem hiding this comment.
Should this trigger on some java directories too? I think the java directory change is the one that actually caused the failure (and I expect this to generally be the case)
There was a problem hiding this comment.
Yeah. It's hard to know where to draw the line. I've added some candidates, and this should get run on postcommit/release as well.
sdks/python/build.gradle
Outdated
| args '-c', "${envdir}/bin/pytest -v apache_beam/yaml/integration_tests.py" | ||
| } | ||
| } | ||
| outputs.file "${buildDir}/yaml-ref.html" |
This should have caught the issue at #30776
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.