Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include everit_json_schema in schemaio expansion service uber jar #30779

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Include everit_json_schema in schemaio expansion service uber jar #30779

merged 1 commit into from
Apr 1, 2024

Conversation

kennknowles
Copy link
Member

I think this fixes #30776

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@kennknowles kennknowles marked this pull request as ready for review March 28, 2024 00:34
@kennknowles
Copy link
Member Author

@Polber can you check if this does what you need?

@kennknowles
Copy link
Member Author

Confirmed:

$ jar -tf sdks/java/extensions/schemaio-expansion-service/build/libs/beam-sdks-java-extensions-schemaio-expansion-service-2.56.0-SNAPSHOT.jar

yields

org/everit/json/
org/everit/json/schema/
org/everit/json/schema/ArraySchema$Builder.class
org/everit/json/schema/ArraySchema.class
org/everit/json/schema/ArraySchemaValidatingVisitor.class
org/everit/json/schema/BooleanSchema$Builder.class
org/everit/json/schema/BooleanSchema.class
org/everit/json/schema/CollectingFailureReporter.class
org/everit/json/schema/CombinedSchema$1.class
org/everit/json/schema/CombinedSchema$2.class
org/everit/json/schema/CombinedSchema$3.class
org/everit/json/schema/CombinedSchema$Builder.class
org/everit/json/schema/CombinedSchema$ValidationCriterion.class
org/everit/json/schema/CombinedSchema.class
org/everit/json/schema/ConditionalSchema$Builder.class
org/everit/json/schema/ConditionalSchema.class
org/everit/json/schema/ConditionalSchemaValidatingVisitor.class
org/everit/json/schema/ConstSchema$ConstSchemaBuilder.class
org/everit/json/schema/ConstSchema.class
org/everit/json/schema/DefaultValidator.class
org/everit/json/schema/EarlyFailingFailureReporter.class
org/everit/json/schema/EmptySchema$Builder.class
org/everit/json/schema/EmptySchema.class
org/everit/json/schema/EnumSchema$Builder.class
org/everit/json/schema/EnumSchema.class
org/everit/json/schema/FalseSchema$Builder.class
org/everit/json/schema/FalseSchema.class
org/everit/json/schema/FormatValidator.class
org/everit/json/schema/InternalValidationException.class
org/everit/json/schema/JSONPointer$Builder.class
org/everit/json/schema/JSONPointer.class
org/everit/json/schema/JSONPointerException.class
org/everit/json/schema/NotSchema$Builder.class
org/everit/json/schema/NotSchema.class
org/everit/json/schema/NullSchema$Builder.class
org/everit/json/schema/NullSchema.class
org/everit/json/schema/NumberComparator.class
org/everit/json/schema/NumberSchema$Builder.class
org/everit/json/schema/NumberSchema.class
org/everit/json/schema/NumberSchemaValidatingVisitor.class
org/everit/json/schema/ObjectComparator.class
org/everit/json/schema/ObjectSchema$Builder.class
org/everit/json/schema/ObjectSchema.class
org/everit/json/schema/ObjectSchemaValidatingVisitor.class
org/everit/json/schema/PrimitiveValidationStrategy.class
org/everit/json/schema/ReadOnlyValidator.class
org/everit/json/schema/ReadWriteContext.class
org/everit/json/schema/ReadWriteValidator.class
org/everit/json/schema/ReferenceSchema$Builder.class
org/everit/json/schema/ReferenceSchema.class
org/everit/json/schema/Schema$Builder.class
org/everit/json/schema/Schema.class
org/everit/json/schema/SchemaException.class
org/everit/json/schema/SchemaLocation.class
org/everit/json/schema/StringSchema$Builder.class
org/everit/json/schema/StringSchema.class
org/everit/json/schema/StringSchemaValidatingVisitor.class
org/everit/json/schema/StringToValueConverter.class
org/everit/json/schema/ToStringVisitor.class
org/everit/json/schema/TrueSchema$Builder.class
org/everit/json/schema/TrueSchema.class
org/everit/json/schema/TypeChecker.class
org/everit/json/schema/ValidatingVisitor.class
org/everit/json/schema/ValidationException.class
org/everit/json/schema/ValidationFailureReporter.class
org/everit/json/schema/Validator$ValidatorBuilder.class
org/everit/json/schema/Validator.class
org/everit/json/schema/Visitor.class
org/everit/json/schema/WriteOnlyValidator.class
org/everit/json/schema/event/
org/everit/json/schema/event/CombinedSchemaMatchEvent.class
org/everit/json/schema/event/CombinedSchemaMismatchEvent.class
org/everit/json/schema/event/CombinedSchemaValidationEvent.class
org/everit/json/schema/event/ConditionalSchemaMatchEvent.class
org/everit/json/schema/event/ConditionalSchemaMismatchEvent.class
org/everit/json/schema/event/ConditionalSchemaValidationEvent$1.class
org/everit/json/schema/event/ConditionalSchemaValidationEvent$Keyword$1.class
org/everit/json/schema/event/ConditionalSchemaValidationEvent$Keyword$2.class
org/everit/json/schema/event/ConditionalSchemaValidationEvent$Keyword$3.class
org/everit/json/schema/event/ConditionalSchemaValidationEvent$Keyword.class
org/everit/json/schema/event/ConditionalSchemaValidationEvent.class
org/everit/json/schema/event/MismatchEvent.class
org/everit/json/schema/event/SchemaReferencedEvent.class
org/everit/json/schema/event/ValidationEvent.class
org/everit/json/schema/event/ValidationListener$1.class
org/everit/json/schema/event/ValidationListener.class
org/everit/json/schema/internal/
org/everit/json/schema/internal/DateFormatValidator.class
org/everit/json/schema/internal/DateTimeFormatValidator$Delegate.class
org/everit/json/schema/internal/DateTimeFormatValidator.class
org/everit/json/schema/internal/EmailFormatValidator.class
org/everit/json/schema/internal/HostnameFormatValidator.class
org/everit/json/schema/internal/IPAddressValidator.class
org/everit/json/schema/internal/IPV4Validator.class
org/everit/json/schema/internal/IPV6Validator.class
org/everit/json/schema/internal/JSONPrinter.class
org/everit/json/schema/internal/JSONWriter.class
org/everit/json/schema/internal/JsonPointerFormatValidator.class
org/everit/json/schema/internal/RegexFormatValidator.class
org/everit/json/schema/internal/RelativeJsonPointerFormatValidator$ParseException.class
org/everit/json/schema/internal/RelativeJsonPointerFormatValidator$Parser.class
org/everit/json/schema/internal/RelativeJsonPointerFormatValidator.class
org/everit/json/schema/internal/TemporalFormatValidator.class
org/everit/json/schema/internal/TimeFormatValidator.class
org/everit/json/schema/internal/URIFormatValidator.class
org/everit/json/schema/internal/URIReferenceFormatValidator.class
org/everit/json/schema/internal/URITemplateFormatValidator.class
org/everit/json/schema/internal/URIV4FormatValidator.class
org/everit/json/schema/loader/
org/everit/json/schema/loader/AbstractSchemaExtractor.class
org/everit/json/schema/loader/AdjacentSchemaExtractionState.class
org/everit/json/schema/loader/ArraySchemaLoader.class
org/everit/json/schema/loader/ClassPathAwareSchemaClient.class
org/everit/json/schema/loader/CombinedSchemaLoader$CombinedSchemaProvider.class
org/everit/json/schema/loader/CombinedSchemaLoader.class
org/everit/json/schema/loader/ConstSchemaExtractor.class
org/everit/json/schema/loader/EnumSchemaExtractor.class
org/everit/json/schema/loader/ExclusiveLimitHandler$1.class
org/everit/json/schema/loader/ExclusiveLimitHandler.class
org/everit/json/schema/loader/ExtractionResult.class
org/everit/json/schema/loader/JsonArray.class
org/everit/json/schema/loader/JsonArrayIterator.class
org/everit/json/schema/loader/JsonObject.class
org/everit/json/schema/loader/JsonObjectIterator.class
org/everit/json/schema/loader/JsonPointerEvaluator$QueryResult.class
org/everit/json/schema/loader/JsonPointerEvaluator.class
org/everit/json/schema/loader/JsonValue$Multiplexer.class
org/everit/json/schema/loader/JsonValue$VoidMultiplexer.class
org/everit/json/schema/loader/JsonValue$VoidMultiplexerWithSchemaPredicate.class
org/everit/json/schema/loader/JsonValue.class
org/everit/json/schema/loader/KeyConsumer.class
org/everit/json/schema/loader/LoaderConfig.class
org/everit/json/schema/loader/LoadingState.class
org/everit/json/schema/loader/NotSchemaExtractor.class
org/everit/json/schema/loader/ObjectSchemaLoader.class
org/everit/json/schema/loader/OrgJsonUtil.class
org/everit/json/schema/loader/ProjectedJsonObject.class
org/everit/json/schema/loader/PropertySnifferSchemaExtractor.class
org/everit/json/schema/loader/ReferenceKnot.class
org/everit/json/schema/loader/ReferenceLookup.class
org/everit/json/schema/loader/ReferenceSchemaExtractor.class
org/everit/json/schema/loader/SchemaClient.class
org/everit/json/schema/loader/SchemaExtractor.class
org/everit/json/schema/loader/SchemaLoader$SchemaLoaderBuilder.class
org/everit/json/schema/loader/SchemaLoader.class
org/everit/json/schema/loader/SpecificationVersion$1.class
org/everit/json/schema/loader/SpecificationVersion$2.class
org/everit/json/schema/loader/SpecificationVersion$3.class
org/everit/json/schema/loader/SpecificationVersion.class
org/everit/json/schema/loader/StringSchemaLoader.class
org/everit/json/schema/loader/SubschemaRegistry.class
org/everit/json/schema/loader/TypeBasedSchemaExtractor.class
org/everit/json/schema/loader/Uri.class
org/everit/json/schema/loader/V4ExclusiveLimitHandler.class
org/everit/json/schema/loader/V6ExclusiveLimitHandler.class
org/everit/json/schema/loader/internal/
org/everit/json/schema/loader/internal/DefaultSchemaClient.class
org/everit/json/schema/loader/internal/JSONPointer$QueryResult.class
org/everit/json/schema/loader/internal/JSONPointer.class
org/everit/json/schema/loader/internal/ReferenceResolver.class
org/everit/json/schema/loader/internal/ResolutionScopeChangeListener.class
org/everit/json/schema/loader/internal/TypeBasedMultiplexer$IdModifyingTypeConsumerImpl.class
org/everit/json/schema/loader/internal/TypeBasedMultiplexer$OnTypeConsumer.class
org/everit/json/schema/loader/internal/TypeBasedMultiplexer$OnTypeConsumerImpl.class
org/everit/json/schema/loader/internal/TypeBasedMultiplexer.class
org/everit/json/schema/loader/internal/WrappingFormatValidator.class
org/everit/json/schema/regexp/
org/everit/json/schema/regexp/AbstractRegexp.class
org/everit/json/schema/regexp/JavaUtilRegexp.class
org/everit/json/schema/regexp/JavaUtilRegexpFactory.class
org/everit/json/schema/regexp/RE2JRegexp.class
org/everit/json/schema/regexp/RE2JRegexpFactory.class
org/everit/json/schema/regexp/Regexp.class
org/everit/json/schema/regexp/RegexpFactory.class
org/everit/json/schema/regexp/RegexpMatchingFailure.class

@github-actions GitHub Actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

damondouglas
damondouglas approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abacn Abacn merged commit 336e870 into apache:master Apr 1, 2024
20 checks passed
damccorm pushed a commit that referenced this pull request Apr 1, 2024
@kennknowles @damccorm
Include everit_json_schema in schemaio expansion service uber jar (#3…
fe9bbb1 
…0779)
damccorm added a commit that referenced this pull request Apr 2, 2024
@damccorm @kennknowles
Include everit_json_schema in schemaio expansion service uber jar (#3…
e9422c2 
…0779) (#30823)

Co-authored-by: Kenn Knowles <[email protected]>
hjtran pushed a commit to hjtran/beam that referenced this pull request Apr 4, 2024
@kennknowles @hjtran
Include everit_json_schema in schemaio expansion service uber jar (ap…
4c04795 
…ache#30779)
@robertwb robertwb mentioned this pull request Apr 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Polber Polber Polber approved these changes

@damondouglas damondouglas damondouglas approved these changes

Assignees
No one assigned
Labels
extensions java Next Action: Reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Beam YAML WriteToJson fails on Beam 2.55
4 participants
@kennknowles @damondouglas @Polber @Abacn