-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcsio: reduce number of get requests in function calls #30205
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
a97ebc8
to
d7f7b43
Compare
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should .get_bucket
in self._gcs_object
also be replaced with .bucket
?
It seems like bucket.get_blob
already makes a HTTP request to check whether the blob exists, or am I missing something?
I checked the code, it should be fine to replace the |
Run Python_Coverage PreCommit |
bucket.delete_blob(blob_name) | ||
|
||
for i, path in enumerate(current_paths): | ||
error_code = None | ||
for j in range(2): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. That was why it needed to be range(2) or range(4) in delete_batch and copy_batch
LGTM |
Checked that tests passed and Comments are resolved, merging for now |
seems this change need to make test change accordingly. PythonPostCommit failing https://github.com/apache/beam/runs/21333859365 |
We replace
client.get_bucket()
withclient.bucket()
, andbucket.get_blob()
withbucket.blob()
in a few places where a lightweight instance of bucket/blob is sufficient for the function calls.The fix reduces unnecessary get requests (from
get_bucket
andget_blob
) in the following gcsio apis:addresses #28398
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.