Flink 1.17 #30197

je-ik · 2024-02-02T16:22:46Z

Support Flink 1.17. Closes #29939.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

github-actions · 2024-02-02T17:34:16Z

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

dmvk

The change looks reasonable overall 👍 My only concern is around the possible compatibility (within the same version) guarantees. PTAL

dmvk · 2024-02-02T18:27:12Z

runners/flink/1.16/build.gradle

@@ -17,14 +17,19 @@
 */

 def basePath = '..'
+def addedVersions = ["1.12", "1.13", "1.14", "1.15"]


nit: previousVersions might be slightly more explicit

I further simplified the build.

dmvk · 2024-02-02T18:34:07Z

...rg/apache/beam/runners/flink/translation/types/compat/UnversionedTypeSerializerSnapshot.java

+  }
+
+  @Override
+  public void writeSnapshot(DataOutputView dataOutputView) throws IOException {


I assume this class was introduced because TypeSerializerConfigSnapshot no longer exists. Should we rather bring the old class in to eliminate the risk (eg. restoring snapshots from the same version)?

By quickly checking the code, it mosly delegates the logic to TypeSerializerSnapshotSerializationUtil which still exists 🤔

https://github.com/apache/flink/blob/release-1.16.3/flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerConfigSnapshot.java

Turns out that provided you preserve the TypeSerializer the TypeSerializerSnapshot can be changed arbitrarily. It can be used to change the TypeSerializer as well, byt we preserve it here.

dmvk · 2024-02-02T18:38:01Z

Can you please link the commits with a corresponding JIRA issue?

je-ik · 2024-02-03T07:54:39Z

Can you please link the commits with a corresponding JIRA issue?

Beam no longer uses JIRA to track issues, but uses github issues instead. The commit is linked with the corresponding issue.

Abacn · 2024-02-15T21:06:39Z

Hi, what is the status of this PR? I see Flink validation runner postcommit test passed. Persumably this is complete?

Abacn · 2024-02-15T21:07:56Z

Also, previously Beam aims to support 4 consecutive flink versions. If find anything hard to support Flink 1.12 (or 1.13) and 1.17 at the same time, feel free to drop the former (or do it later)

je-ik · 2024-02-16T07:05:48Z

I need to polish and validate upgrade path so this is temporarily on hold.

JozoVilcek · 2024-02-21T08:29:52Z

.../1.12/src/main/java/org/apache/beam/runners/flink/translation/types/CoderTypeSerializer.java

+   * org.apache.beam.sdk.io.FileSystems} registration needed for {@link
+   * org.apache.beam.sdk.transforms.Reshuffle} translation.
+   */
+  private final SerializablePipelineOptions pipelineOptions;


What does this comment really mean for this class? From what I can tell, filesystem registration happens when constructing serializable pipeline options, which is not being done here.

Do we actually need to keep this as a member?

This was just moved from main sources due to the fact it needs to be customized for Flink 1.17.

je-ik · 2024-02-21T15:34:26Z

The upgrade is currently broken due to https://lists.apache.org/thread/s8o8jc2k2kb41q5g0v0xmoyszg1gdcst. After decision is made about the next steps this PR can continue.

Abacn · 2024-04-04T14:43:23Z

Hi, as https://lists.apache.org/thread/s8o8jc2k2kb41q5g0v0xmoyszg1gdcst gets resolved by #30403, is this PR ready to be merged?

je-ik · 2024-04-04T14:47:35Z

Hi, unfortunately I did not have time to finish it, yet. But target is currently release 2.56.0.

Abacn · 2024-04-04T14:50:42Z

Thanks, that's awesome!

je-ik · 2024-04-12T08:17:39Z

I verified the current implementation works and can read savepoint created by 1.16 (at least with the same beam version), but I need more tests regarding upgrade from current stable release. Moreover there is issue #29816 which seems to affect the current release as well. I would like to release 'new' runner without known severe bugs, so I think this should wait for one more release.

je-ik · 2024-04-16T10:03:58Z

Unfortunately, upgrading Flink has still issues with upgrading various sources (due to Java serialization). Upgrade from 2.55.0 to 2.56.0 (in my testing Pipeline) is blocked due to incompatible change of KafkaIO.Read (added option).

Having said that, upgrade from 2.56.0 Flink 1.16 to Flink 1.17 works and that is as far as we can get. We need to merge #30987 and then we would need to implement #30385 and ideally #21897.

Other than that, this is ready from my part @Abacn, with follow-up #30988.

Abacn · 2024-04-16T17:04:17Z

KafkaIO option change is #30877. It was having issue on upgrade compatibility. Let me check with the author if #30915 has fixed the upgrade issue

je-ik · 2024-04-16T17:35:28Z

I don't think we can do anything about that at this point. I tried adding serialVersionUID, but it ends on incompatible change of the AutoValue generated class. Upgrading KafkaIO has been for this reason broken several times in last releases, we need to resolve the underlying issue (not serializing sources to checkpoint using Serializable interface). Which will again be upgrade-breaking change.

Abacn

Thanks, just have a minor comment about build file

Abacn · 2024-04-16T21:12:36Z

runners/flink/flink_runner.gradle

+  versions.collect { "${base_path}/${it}/src/${type}/java" } + ["./src/${type}/java"]
+}
+
+def all_versions = ['1.12', '1.13', '1.14', '1.15', '1.16', '1.17']


can we get these values from gradle.properties so keep a single path maintaining the versions? Just use

def all_versions = project.flink_versions.split(',')

Yes, I've done this here 👍

Abacn · 2024-04-16T21:18:14Z

runners/flink/1.12/build.gradle

  flink_version = '1.12.7'
-  // Version specific code overrides.
-  main_source_overrides = ['./src/main/java']
-  test_source_overrides = ['./src/test/java']


thanks for doing these refactorings

Abacn

Thanks, just have a minor comment about build file

Abacn

Thank you!

github-actions bot added build website runners flink labels Feb 2, 2024

je-ik requested a review from dmvk February 2, 2024 16:23

je-ik force-pushed the flink-1.17 branch 2 times, most recently from b718751 to 9e4b03f Compare February 2, 2024 17:45

github-actions bot removed the website label Feb 2, 2024

je-ik force-pushed the flink-1.17 branch from 9e4b03f to 9db0954 Compare February 2, 2024 18:12

dmvk reviewed Feb 2, 2024

View reviewed changes

je-ik changed the title ~~Flink 1.17~~ [DO NOT MERGE] Flink 1.17 Feb 16, 2024

github-actions bot added the website label Feb 19, 2024

JozoVilcek reviewed Feb 21, 2024

View reviewed changes

thebozzcl mentioned this pull request Mar 28, 2024

[Feature Request]: Support for Apache Flink 1.18 in Beam Runners #30789

Closed

16 tasks

je-ik force-pushed the flink-1.17 branch from 66a9438 to 42bd6a1 Compare April 11, 2024 12:32

[flink] add support for Flink 1.17 (apache#29939)

deee0e9

je-ik force-pushed the flink-1.17 branch from 42bd6a1 to deee0e9 Compare April 12, 2024 08:19

je-ik changed the title ~~[DO NOT MERGE] Flink 1.17~~ Flink 1.17 Apr 16, 2024

This was referenced Apr 16, 2024

[#30870]: support consumer polling timeout in KafkaIO expansion service #30915

Merged

[Bug]: New option in KafkaIO.Read breaks upgrade compatibility #30997

Closed

Abacn reviewed Apr 16, 2024

View reviewed changes

Abacn approved these changes Apr 17, 2024

View reviewed changes

je-ik merged commit d70c253 into apache:master Apr 17, 2024
35 checks passed

je-ik deleted the flink-1.17 branch April 17, 2024 14:52

damccorm mentioned this pull request May 3, 2024

Fix flink versioning issues #31168

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Flink 1.17 #30197

Flink 1.17 #30197

je-ik commented Feb 2, 2024

github-actions bot commented Feb 2, 2024

dmvk left a comment

dmvk Feb 2, 2024

je-ik Apr 16, 2024

dmvk Feb 2, 2024

je-ik Apr 16, 2024

dmvk commented Feb 2, 2024 •

edited

Loading

je-ik commented Feb 3, 2024

Abacn commented Feb 15, 2024

Abacn commented Feb 15, 2024

je-ik commented Feb 16, 2024 •

edited

Loading

JozoVilcek Feb 21, 2024

JozoVilcek Feb 21, 2024

je-ik Feb 21, 2024

je-ik commented Feb 21, 2024

Abacn commented Apr 4, 2024

je-ik commented Apr 4, 2024

Abacn commented Apr 4, 2024

je-ik commented Apr 12, 2024

je-ik commented Apr 16, 2024

Abacn commented Apr 16, 2024

je-ik commented Apr 16, 2024 •

edited

Loading

Abacn left a comment

Abacn Apr 16, 2024

je-ik Apr 17, 2024

Abacn Apr 16, 2024

Abacn left a comment

Abacn left a comment

Flink 1.17 #30197

Flink 1.17 #30197

Conversation

je-ik commented Feb 2, 2024

Support Flink 1.17. Closes #29939.

GitHub Actions Tests Status (on master branch)

github-actions bot commented Feb 2, 2024

dmvk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmvk commented Feb 2, 2024 • edited Loading

je-ik commented Feb 3, 2024

Abacn commented Feb 15, 2024

Abacn commented Feb 15, 2024

je-ik commented Feb 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

je-ik commented Feb 21, 2024

Abacn commented Apr 4, 2024

je-ik commented Apr 4, 2024

Abacn commented Apr 4, 2024

je-ik commented Apr 12, 2024

je-ik commented Apr 16, 2024

Abacn commented Apr 16, 2024

je-ik commented Apr 16, 2024 • edited Loading

Abacn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Abacn left a comment

Choose a reason for hiding this comment

Abacn left a comment

Choose a reason for hiding this comment

dmvk commented Feb 2, 2024 •

edited

Loading

je-ik commented Feb 16, 2024 •

edited

Loading

je-ik commented Apr 16, 2024 •

edited

Loading