Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply mitigation #27330 for 2.53.0 #29703

Closed
wants to merge 3 commits into from
Closed

Conversation

tvalentyn
Copy link
Contributor

I am investigating a process corruption that became very pronounced in streaming pipelines after protobuf 4 upgrade #27330 .
Since:

  1. there is still no rootcause for [Bug]: Python SDK sometimes crashes in streaming jobs running on 2.47.0+ SDK #27330;
  2. some customers insist that Beam must support protobuf v4;
  3. issue seems limited to streaming pipelines;
  4. protobuf 4.25 is expected to be forwards-compatible with 3.20.x ,

I propose to install Protobuf 3.20 by default into Beam SDK container until we have a fix for #27330.

@tvalentyn
Copy link
Contributor Author

R: @jrmccluskey

Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (218af9d) 37.99% compared to head (e173b4d) 37.99%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #29703   +/-   ##
=======================================
  Coverage   37.99%   37.99%           
=======================================
  Files         691      691           
  Lines      101334   101334           
=======================================
  Hits        38499    38499           
  Misses      61236    61236           
  Partials     1599     1599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrmccluskey
Copy link
Contributor

The Docker pre-commit is failing with a dependency issue:

89.88 [nltk_data] Downloading package stopwords to /root/nltk_data...
89.94 [nltk_data]   Unzipping corpora/stopwords.zip.
90.14 Traceback (most recent call last):
90.14   File "<string>", line 1, in <module>
90.14 AssertionError
90.14 Container does not include required Beam dependencies or has conflicting dependencies. If Beam dependencies have changed, you need to regenerate base_image_requirements.txt files. See: https://s.apache.org/beam-python-requirements-generate

@tvalentyn
Copy link
Contributor Author

Thanks, added e173b4d to fix.

@tvalentyn
Copy link
Contributor Author

looks like still failing for 3.11, looking further

@tvalentyn
Copy link
Contributor Author

looks like fast implementation is not available on 3.11 with protobuf 3 :(.

@tvalentyn tvalentyn marked this pull request as draft December 11, 2023 17:10
@tvalentyn tvalentyn closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants