-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply mitigation #27330 for 2.53.0 #29703
Conversation
R: @jrmccluskey |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29703 +/- ##
=======================================
Coverage 37.99% 37.99%
=======================================
Files 691 691
Lines 101334 101334
=======================================
Hits 38499 38499
Misses 61236 61236
Partials 1599 1599 ☔ View full report in Codecov by Sentry. |
The Docker pre-commit is failing with a dependency issue:
|
Thanks, added e173b4d to fix. |
looks like still failing for 3.11, looking further |
looks like fast implementation is not available on 3.11 with protobuf 3 :(. |
I am investigating a process corruption that became very pronounced in streaming pipelines after protobuf 4 upgrade #27330 .
Since:
I propose to install Protobuf 3.20 by default into Beam SDK container until we have a fix for #27330.