Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Skip fastavro 1.8.4 #28871

Closed
wants to merge 1 commit into from

Conversation

riteshghorse
Copy link
Contributor

Skip fastavro 1.8.4 because of a regression caught in #28811


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@riteshghorse
Copy link
Contributor Author

Run Python 3.8 PostCommit

@riteshghorse
Copy link
Contributor Author

Run Python 3.9 PostCommit

@riteshghorse
Copy link
Contributor Author

Run Python 3.10 PostCommit

@riteshghorse
Copy link
Contributor Author

Run Python 3.11 PostCommit

@github-actions github-actions bot added the python label Oct 6, 2023
@riteshghorse
Copy link
Contributor Author

Run Python_Dataframes PreCommit

@riteshghorse
Copy link
Contributor Author

Run Python_PVR_Flink PreCommit

@riteshghorse
Copy link
Contributor Author

Run Python_Coverage PreCommit

@riteshghorse
Copy link
Contributor Author

R: @tvalentyn

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

tvalentyn
tvalentyn previously approved these changes Oct 6, 2023
@Abacn
Copy link
Contributor

Abacn commented Oct 6, 2023

it's not sure if this will get fixed in 1.8.5 onward, should we set upper bound version instead?

@tvalentyn
Copy link
Contributor

Yes, I'm actually thinking about the same thing after looking at trace in fastavro/fastavro#720

@riteshghorse
Copy link
Contributor Author

I raised an issue with them. Let's see if that is included in next release. If not, we can set upper bound I think

@tvalentyn
Copy link
Contributor

if it is a submission-runtime compatibility , rebuilding Dataflow containers to include latest fastavro version will fix it.

@tvalentyn
Copy link
Contributor

and we don't need to change versions.

@tvalentyn
Copy link
Contributor

but that doesn't explain why some external users got affected. i am not sure I completely understand the failure mode here.

@Abacn
Copy link
Contributor

Abacn commented Oct 6, 2023

Also note that it only fails on direct and flink runner test. Dataflow running same test having no issue - so it is likely a test config issue (e.g. mismatch version) get revealed

@tvalentyn tvalentyn dismissed their stale review October 6, 2023 20:21

let's look closer into failure cause to understand it first.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #28871 (79f8519) into master (af9da31) will decrease coverage by 0.01%.
Report is 17 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28871      +/-   ##
==========================================
- Coverage   72.20%   72.20%   -0.01%     
==========================================
  Files         684      685       +1     
  Lines      101235   101474     +239     
==========================================
+ Hits        73101    73267     +166     
- Misses      26558    26631      +73     
  Partials     1576     1576              
Flag Coverage Δ
python 82.70% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/setup.py 0.00% <ø> (ø)

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@riteshghorse
Copy link
Contributor Author

Scott mentioned about catching EOFError as well along with StopIteration fastavro/fastavro#720 (comment). Closing this one in favor of #28896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants