Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Tensorflow from default Beam images. #28424

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Sep 12, 2023

Including TF significantly increases the size of default Beam container images. Given that some Beam users use other ML framework, including TF but not other, equally large dependencies, seems less obvious.

I suggest we remove TF for now, which shaves almost 1.5 GB from unpacked image.

If you have been negatively affected by this change, please comment on #20605 - we would like to collect user input to prioritize this effort accordingly.

For tips on Python runtime dependency management, see : https://beam.apache.org/documentation/sdks/python-pipeline-dependencies.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@lostluck
Copy link
Contributor

The 2.50 images were around 4.13GB (according to my local docker). What's the new total without tensor flow? (It would be good to have in the PR description anyway).

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #28424 (f679ff8) into master (846a1ab) will increase coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28424      +/-   ##
==========================================
+ Coverage   72.33%   72.35%   +0.01%     
==========================================
  Files         682      682              
  Lines      100541   100541              
==========================================
+ Hits        72730    72748      +18     
+ Misses      26238    26216      -22     
- Partials     1573     1577       +4     
Flag Coverage Δ
go 53.66% <ø> (+0.04%) ⬆️
python 82.87% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tvalentyn
Copy link
Contributor Author

The 2.50 images were around 4.13GB (according to my local docker). What's the new total without tensor flow? (It would be good to have in the PR description anyway).

This number (unpacked image) reduces to 2.67 GB

Copy link
Contributor

@bvolpato bvolpato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me. LGTM.

Might be good to send a note to users@ and/or highlight this when the release is coming out

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@tvalentyn tvalentyn merged commit 9f3bea9 into apache:master Sep 12, 2023
81 of 82 checks passed
@tvalentyn tvalentyn deleted the tf_img branch September 12, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants