Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the monkey-patch with backport of newer changes to dill pickler also in Python 3.10. #28355

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Sep 7, 2023

This should help with the segfault portion of #27330.

Use backported dill changes also in Python 3.10.
@github-actions github-actions bot added the python label Sep 7, 2023
@tvalentyn tvalentyn changed the title Update dill_pickler.py Apply the monkey-patch with backport of newer changes to dill pickler also in Python 3.10. Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #28355 (480de57) into master (5cc8709) will decrease coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #28355      +/-   ##
==========================================
- Coverage   72.33%   72.33%   -0.01%     
==========================================
  Files         681      681              
  Lines      100355   100357       +2     
==========================================
+ Hits        72593    72594       +1     
- Misses      26185    26186       +1     
  Partials     1577     1577              
Flag Coverage Δ
python 82.90% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...on/apache_beam/ml/inference/vertex_ai_inference.py 44.92% <50.00%> (+0.15%) ⬆️
sdks/python/apache_beam/internal/dill_pickler.py 77.91% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@tvalentyn
Copy link
Contributor Author

cc: @iindyk

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvalentyn tvalentyn merged commit 4bccd45 into master Sep 7, 2023
90 of 91 checks passed
@tvalentyn tvalentyn deleted the tvalentyn-patch-1 branch September 7, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants