Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all Beam released container images multi-arch. #27936

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

celeste-zeng
Copy link
Contributor

@celeste-zeng celeste-zeng commented Aug 9, 2023

  • Changed all related docker task to have flags to build multi-arch containers.
  • Updated all related dockerPush tasks to be docker, since images are pushed during build.\
  • Updated CHANGES.md.
    Tested by running the exact release gradle target here, every multi-arch container was built successfully.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #27936 (b9b63e5) into master (4122e96) will increase coverage by 0.01%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #27936      +/-   ##
==========================================
+ Coverage   70.58%   70.59%   +0.01%     
==========================================
  Files         857      857              
  Lines      103947   103947              
==========================================
+ Hits        73370    73381      +11     
+ Misses      29018    29004      -14     
- Partials     1559     1562       +3     
Flag Coverage Δ
go 53.68% <ø> (-0.02%) ⬇️
python 79.57% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@celeste-zeng
Copy link
Contributor Author

R: @tvalentyn @lostluck

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@lostluck lostluck added this to the 2.50.0 Release milestone Aug 9, 2023
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just re-running that one failed java test.

@lostluck lostluck merged commit f07fe40 into apache:master Aug 9, 2023
97 checks passed
@celeste-zeng celeste-zeng deleted the all-multiarch branch August 12, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants