Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#24789] Mention prism is the new default Go SDK runner in CHANGES.md #27816

Merged
merged 3 commits into from
Aug 2, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Aug 2, 2023

Mention default runner change.
Light advice for migrating off of the direct runner.

Clarify scope of legacy runner deprecation mention to Python.

See #24789 for Prism replacement.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@lostluck
Copy link
Contributor Author

lostluck commented Aug 2, 2023

R: @damccorm

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

CHANGES.md Outdated Show resolved Hide resolved
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though I'd appreciate the recommended change, it is optional)

@lostluck lostluck merged commit 427e0a1 into apache:master Aug 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants