-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flags to build multiarch Java SDK containers and test #27760
Conversation
… for multiarch containers
…ut Java version and Java home issues.
…t build.gradle file.
Codecov Report
@@ Coverage Diff @@
## master #27760 +/- ##
=======================================
Coverage 70.88% 70.89%
=======================================
Files 861 861
Lines 105005 105005
=======================================
+ Hits 74437 74440 +3
+ Misses 29009 29007 -2
+ Partials 1559 1558 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! just had a few comments
.github/workflows/beam_PostCommit_Java_Examples_Dataflow_ARM.yml
Outdated
Show resolved
Hide resolved
.github/workflows/beam_PostCommit_Java_Examples_Dataflow_ARM.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Danny McCormick <[email protected]>
Co-authored-by: Danny McCormick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM
- 'examples/java/**' | ||
- 'examples/kotlin/**' | ||
- 'release/**' | ||
- '.github/workflows/beam_PostCommit_Java_Examples__Dataflow_ARM.yml' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: redundant underscore here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted, thanks for catching it!
* Add a new gradle file. * Removed all legacy worker related tasks in build.gradle, adjust tasks for multiarch containers * Created new files for Java Dataflow ARM tests, still need to figure out Java version and Java home issues. * Remove unused code in build.gradle. * remove unused target, add build multiarch Java container flags, adjust build.gradle file. * Add the TAG as env variable shared by diff Java version tests. * Adjust dependencies. * Change READNE for Java versions and yml file for auth. * Made changes based on PR comments. * Made changes based on comments, standardize yml file. * Change github_job. * Update .github/workflows/beam_PostCommit_Java_Examples_Dataflow_ARM.yml Co-authored-by: Danny McCormick <[email protected]> * Update .github/workflows/beam_PostCommit_Java_Examples_Dataflow_ARM.yml Co-authored-by: Danny McCormick <[email protected]> * remove redundant underscore --------- Co-authored-by: Danny McCormick <[email protected]>
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.