Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags to build multiarch Java SDK containers and test #27760

Merged
merged 18 commits into from
Aug 3, 2023

Conversation

celeste-zeng
Copy link
Contributor

  • Use new flags to build and push multi-arch Java containers(will not affect the current building of x86 containers if flags are not specified during build);
  • Add a arm/build.gradle file so it builds and pushes a multi-arch Java container, and use it to run a dataflow pipeline.
  • Add a yml file so that the test will be triggered by Github Actions.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #27760 (2793848) into master (13dd74c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #27760   +/-   ##
=======================================
  Coverage   70.88%   70.89%           
=======================================
  Files         861      861           
  Lines      105005   105005           
=======================================
+ Hits        74437    74440    +3     
+ Misses      29009    29007    -2     
+ Partials     1559     1558    -1     
Flag Coverage Δ
go 53.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! just had a few comments

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

- 'examples/java/**'
- 'examples/kotlin/**'
- 'release/**'
- '.github/workflows/beam_PostCommit_Java_Examples__Dataflow_ARM.yml'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: redundant underscore here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted, thanks for catching it!

@Abacn Abacn merged commit 553ac16 into apache:master Aug 3, 2023
18 checks passed
@celeste-zeng celeste-zeng deleted the gh-java-arm branch August 3, 2023 16:45
BjornPrime pushed a commit to BjornPrime/my-beam that referenced this pull request Aug 7, 2023
* Add a new gradle file.

* Removed all legacy worker related tasks in build.gradle, adjust tasks for multiarch containers

* Created new files for Java Dataflow ARM tests, still need to figure out Java version and Java home issues.

* Remove unused code in build.gradle.

* remove unused target, add build multiarch Java container flags, adjust build.gradle file.

* Add the TAG as env variable shared by diff Java version tests.

* Adjust dependencies.

* Change READNE for Java versions and yml file for auth.

* Made changes based on PR comments.

* Made changes based on comments, standardize yml file.

* Change github_job.

* Update .github/workflows/beam_PostCommit_Java_Examples_Dataflow_ARM.yml

Co-authored-by: Danny McCormick <[email protected]>

* Update .github/workflows/beam_PostCommit_Java_Examples_Dataflow_ARM.yml

Co-authored-by: Danny McCormick <[email protected]>

* remove redundant underscore

---------

Co-authored-by: Danny McCormick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants